Merged
Conversation
Adds "Users who did not pass fraud review" to report. changelog: Internal, Reporting, Adds users failing fraud review to DIVR
n1zyy
commented
May 31, 2024
| # @param [Boolean] gpo_verification_pending Profile is awaiting gpo verificaiton | ||
| # @param [Boolean] in_person_verification_pending Profile is awaiting in person verificaiton | ||
| # @param [Boolean] gpo_verification_pending Profile is awaiting gpo verification | ||
| # @param [Boolean] in_person_verification_pending Profile is awaiting in person verification |
Contributor
Author
There was a problem hiding this comment.
Pet peeve change while I was poking through here. 😇
| csv << ['Workflow completed - In-Person Pending', idv_final_resolution_in_person] | ||
| csv << ['Workflow completed - Fraud Review Pending', idv_final_resolution_fraud_review] | ||
| csv << [] | ||
| csv << ['Users who did not pass fraud review', idv_fraud_rejected] |
Contributor
Author
There was a problem hiding this comment.
idv_fraud_rejected is already present; it just wasn't included in the Daily IdV Report.
Contributor
There was a problem hiding this comment.
"did not pass" sounds to me like it would include "fraud review pending" as well as "fraud review rejected", WDYT of making the title clearer here?
Suggested change
| csv << ['Users who did not pass fraud review', idv_fraud_rejected] | |
| csv << ['Fraud review rejected', idv_fraud_rejected] |
Contributor
Author
There was a problem hiding this comment.
Clearer and simpler. I love it.
zachmargolis
approved these changes
May 31, 2024
| csv << ['Workflow completed - In-Person Pending', idv_final_resolution_in_person] | ||
| csv << ['Workflow completed - Fraud Review Pending', idv_final_resolution_fraud_review] | ||
| csv << [] | ||
| csv << ['Users who did not pass fraud review', idv_fraud_rejected] |
Contributor
There was a problem hiding this comment.
"did not pass" sounds to me like it would include "fraud review pending" as well as "fraud review rejected", WDYT of making the title clearer here?
Suggested change
| csv << ['Users who did not pass fraud review', idv_fraud_rejected] | |
| csv << ['Fraud review rejected', idv_fraud_rejected] |
matthinz
approved these changes
May 31, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12295
🛠 Summary of changes
This ticket asked to add 3 things to the daily IdV report:
(As noted in the ticket, this is the same value as "IDV Rejected (Fraud)" in the MKMR.)
Open to debate is how to organize these metrics. I just added a row somewhere reasonable-looking, but we could potentially move these metrics to a separate Fraud Stats section or something?