Skip to content

LG-12086 | Renames CaptureDocStatusController #10615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1zyy merged 2 commits into from
May 14, 2024
Merged

LG-12086 | Renames CaptureDocStatusController #10615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32c6eb
LG-12086 | Renames CaptureDocStatusController
n1zyy May 13, 2024
30822ef
Fixes broken link. D'oh!
n1zyy May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lers/idv/capture_doc_status_controller.rb → ...trollers/idv/link_sent_poll_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

module Idv
class CaptureDocStatusController < ApplicationController
class LinkSentPollController < ApplicationController
Copy link
Copy Markdown
Contributor Author

@n1zyy n1zyy May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note from the filename at the top that this (and the test) are also renamed. GitHub doesn't make this super obvious.

include Idv::AvailabilityConcern

before_action :confirm_two_factor_authenticated
Expand Down
2 changes: 1 addition & 1 deletion app/views/idv/link_sent/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

<% if FeatureManagement.doc_capture_polling_enabled? %>
<%= content_tag 'script', '', data: {
status_endpoint: idv_capture_doc_status_url,
status_endpoint: idv_link_sent_poll_url,
} %>
<%= javascript_packs_tag_once 'doc-capture-polling' %>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@
put '/hybrid_handoff' => 'hybrid_handoff#update'
get '/link_sent' => 'link_sent#show'
put '/link_sent' => 'link_sent#update'
get '/link_sent/poll' => 'capture_doc_status#show', as: :capture_doc_status
Copy link
Copy Markdown
Contributor

@aduth aduth May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be at least one reference to the capture_doc_status name that needs to be updated?

identity-idp/app/views/idv/link_sent/show.html.erb

Line 45 in b32c6eb

status_endpoint: idv_capture_doc_status_url,

Copy link
Copy Markdown
Contributor Author

@n1zyy n1zyy May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I think we found this about simultaneously. This was the only reference.

get '/link_sent/poll' => 'link_sent_poll#show'
get '/ssn' => 'ssn#show'
put '/ssn' => 'ssn#update'
get '/verify_info' => 'verify_info#show'
Expand Down
2 changes: 1 addition & 1 deletion ...idv/capture_doc_status_controller_spec.rb → ...ers/idv/link_sent_poll_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require 'rails_helper'

RSpec.describe Idv::CaptureDocStatusController do
RSpec.describe Idv::LinkSentPollController do
let(:user) { build(:user) }
let(:doc_auth_response) do
DocAuth::Response.new(
Expand Down