Skip to content

LG-12086 | Renames CaptureDocStatusController#10615

Merged
n1zyy merged 2 commits intomainfrom
mattw/LG-12086_rename_CaptureDocStatusController
May 14, 2024
Merged

LG-12086 | Renames CaptureDocStatusController#10615
n1zyy merged 2 commits intomainfrom
mattw/LG-12086_rename_CaptureDocStatusController

Conversation

@n1zyy
Copy link
Copy Markdown
Contributor

@n1zyy n1zyy commented May 13, 2024

changelog: Internal, Tech Debt, Renames CaptureDocStatusController to LinkSentPollController

🎫 Ticket

Link to the relevant ticket:
LG-12086

🛠 Summary of changes

From the ticket:

The name is left over from the FlowStateMachine. What it does is poll to see if hybrid flow DocumentCapture is complete. The route has already been renamed to /link_sent/poll

This updates the name to match.

changelog: Internal, Tech Debt, Renames CaptureDocStatusController to LinkSentPollController
put '/hybrid_handoff' => 'hybrid_handoff#update'
get '/link_sent' => 'link_sent#show'
put '/link_sent' => 'link_sent#update'
get '/link_sent/poll' => 'capture_doc_status#show', as: :capture_doc_status
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be at least one reference to the capture_doc_status name that needs to be updated?

status_endpoint: idv_capture_doc_status_url,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I think we found this about simultaneously. This was the only reference.


module Idv
class CaptureDocStatusController < ApplicationController
class LinkSentPollController < ApplicationController
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note from the filename at the top that this (and the test) are also renamed. GitHub doesn't make this super obvious.

@n1zyy n1zyy requested a review from a team May 13, 2024 20:40
@n1zyy n1zyy merged commit f9cc372 into main May 14, 2024
@n1zyy n1zyy deleted the mattw/LG-12086_rename_CaptureDocStatusController branch May 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants