Skip to content

LG-13007: clean up exit survey related. #10572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dawei-nava merged 2 commits into from
May 10, 2024
Merged

LG-13007: clean up exit survey related. #10572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86d59ba
LG-13007: clean up further.
dawei-nava May 8, 2024
c27f1e6
LG-13007: remove commented out part
dawei-nava May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions app/controllers/idv/cancellations_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,6 @@ def destroy
end
end

def exit
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see when this was added, but I'm glad we're removing. I think exit is a bad name for an action because it shadows the Kernel#exit method built into every Ruby object, the one that exits the program, it would be a bad mistake for code to call #exit on the wrong object instead of this controller

analytics.idv_cancellation_confirmed(step: params[:step])
cancel_session
if hybrid_session?
render :destroy
else
redirect_to cancelled_redirect_path
end
end

private

def barcode_step?
Expand Down
1 change: 0 additions & 1 deletion app/javascript/packages/verify-flow/cancel.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ describe('Cancel', () => {
value={{
accountURL: 'http://example.test/account',
cancelURL: 'http://example.test/cancel',
exitURL: 'http://example.test/exit',
currentStep: 'one',
}}
>
Expand Down
7 changes: 0 additions & 7 deletions app/javascript/packages/verify-flow/context/flow-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ export interface FlowContextValue {
* URL to path for session cancel.
*/
cancelURL: string;

/**
* URL to exit session without confirmation
*/
exitURL: string;

/**
* Current step name.
*/
Expand All @@ -24,7 +18,6 @@ export interface FlowContextValue {
const FlowContext = createContext<FlowContextValue>({
accountURL: '',
cancelURL: '',
exitURL: '',
currentStep: '',
});

Expand Down
3 changes: 0 additions & 3 deletions app/javascript/packs/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ interface AppRootData {
acuantVersion: string;
flowPath: FlowPath;
cancelUrl: string;
exitUrl: string;
idvInPersonUrl?: string;
optedInToInPersonProofing: string;
securityAndPrivacyHowItWorksUrl: string;
Expand Down Expand Up @@ -95,7 +94,6 @@ const {
acuantVersion,
flowPath,
cancelUrl: cancelURL,
exitUrl: exitURL,
accountUrl: accountURL,
idvInPersonUrl: inPersonURL,
securityAndPrivacyHowItWorksUrl: securityAndPrivacyHowItWorksURL,
Expand Down Expand Up @@ -171,7 +169,6 @@ const App = composeComponents(
value: {
accountURL,
cancelURL,
exitURL,
currentStep: 'document_capture',
},
},
Expand Down
1 change: 0 additions & 1 deletion app/views/idv/shared/_document_capture.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
sp_name: sp_name,
flow_path: flow_path,
cancel_url: idv_cancel_path(step: :document_capture),
exit_url: idv_exit_path,
account_url: account_path,
failure_to_proof_url: failure_to_proof_url,
opted_in_to_in_person_proofing: opted_in_to_in_person_proofing,
Expand Down
1 change: 0 additions & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,6 @@
get '/cancel/' => 'cancellations#new', as: :cancel
put '/cancel' => 'cancellations#update'
delete '/cancel' => 'cancellations#destroy'
get '/exit' => 'cancellations#exit', as: :exit
get '/address' => 'address#new'
post '/address' => 'address#update'
get '/capture_doc' => 'hybrid_mobile/entry#show'
Expand Down