LG-13007: clean up exit survey related.#10572
Merged
dawei-nava merged 2 commits intomainfrom May 10, 2024
Merged
Conversation
changelog: Internal, Doc Auth, Clean up exit survey
Contributor
Author
|
Most already cleaned up in Apr. |
aduth
approved these changes
May 8, 2024
zachmargolis
approved these changes
May 10, 2024
| end | ||
| end | ||
|
|
||
| def exit |
Contributor
There was a problem hiding this comment.
I didn't see when this was added, but I'm glad we're removing. I think exit is a bad name for an action because it shadows the Kernel#exit method built into every Ruby object, the one that exits the program, it would be a bad mistake for code to call #exit on the wrong object instead of this controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13007
📜 Testing Plan
Covered by unit and feature test.