Reinstall Express dependencies for webpack-dev-server advisory#10430
Merged
Reinstall Express dependencies for webpack-dev-server advisory#10430
Conversation
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
mitchellhenke
approved these changes
Apr 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates resolved versions of
expressandfollow-redirectsto resolve outstanding security advisories, as transitive dependencies ofwebpack-dev-server.This was meant to be addressed in #10350, but the updated version of
webpack-dev-serverdid not require a minimum version ofexpressandfollow-redirectsto resolve the advisory.The process for performing this update was to manually remove top-level entries of
expressandfollow-redirectsfromyarn.lockand runningyarn installto allow the latest version of the dependencies that satisfies the version constraints of their ancestor dependency (webpack-dev-server). This is something that a tool likenpm audit fixwould automate for us, but an equivalent tool does not exist in Yarn Classic.📜 Testing Plan
Verify no errors or changes to
yarn.lockafter runningyarn install(this is also verified through CI):Verify that
yarn auditis empty afteryarn install.