Upgrade Webpack dependencies to resolve security advisories#10350
Merged
Upgrade Webpack dependencies to resolve security advisories#10350
Conversation
changelog: Internal, Dependencies, Upgrade dependencies to latest versions to resolve security advisories
mitchellhenke
approved these changes
Apr 2, 2024
Random but deterministic
zachmargolis
approved these changes
Apr 2, 2024
| 'actual946.en.js', | ||
| 'actual946.es.js', | ||
| 'actual946.fr.js', | ||
| 'actual278.en.js', |
Contributor
There was a problem hiding this comment.
is it a valuable test to hardcode the specific files? would it make sense to have like a count + regex approach?
Contributor
Author
There was a problem hiding this comment.
I'll check again in the morning if there's a strong reason to test them specifically. I think I wasn't expecting the suffix to change all that often since it's meant to be deterministic, but this isn't the first time I've had to update these as part of a version upgrade.
Contributor
Author
There was a problem hiding this comment.
I updated this in 6452166 to be hopefully more resilient to these sorts of deterministic ID changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Upgrades Webpack-related dependencies to their latest versions.
Initially this was targeted at
webpack-dev-server, which has some related open security advisories (GHSA-wr3j-pwj9-hqq6, GHSA-rv95-896h-c2vc, GHSA-cxjh-pqwp-8mfp), but I decided to upgrade a few others sincewebpack-dev-serverat least required a version bump ofwebpack-clito >5.0.Related CHANGELOG:
These security updates don't block builds since we only check for dependencies installed in production environments, but it's prudent to resolve them, and minimizes noise in the GitHub UI and push messages..
📜 Testing Plan
yarn installmake run