Stop adding updated address to idv_session.pii_from_doc#10393
Merged
Conversation
Contributor
Author
|
This cannot be merged until the changes in #10390 are merged |
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
e3d3054 to
8c6e8c1
Compare
jmhooper
force-pushed
the
jmhooper-stop-writing-address-to-pii-from-doc
branch
2 times, most recently
from
31127b0 to
8377a5a
Compare
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
4 times, most recently
from
77e8f30 to
38dc46c
Compare
Base automatically changed from
jmhooper-read-address-data-from-session
to
main
April 16, 2024 14:34
In #10390 we started using the new `idv_session.updated_user_address` value to represent the user address if it is present. This allows us to stop overwriting the user address that was on the document in `pii_from_doc`. We were not able to actually take this step because of the 50/50 state issues related to session updates. This commit stops overwriting the PII from the document in `pii_from_doc` when a new address is provided in `Idv::AddressController` [skip changelog]
jmhooper
force-pushed
the
jmhooper-stop-writing-address-to-pii-from-doc
branch
from
8377a5a to
1748a5d
Compare
Contributor
Author
|
The changes from #10390 were included in the latest release. This should be ready for review. |
matthinz
reviewed
Apr 17, 2024
| end.to change { subject.idv_session.address_edited }.from(nil).to eql(true) | ||
| end | ||
|
|
||
| it 'updates pii_from_doc in idv_session' do |
Contributor
There was a problem hiding this comment.
Maybe we should invert this test (assert that pii_from_doc is not modified?)
Contributor
Author
There was a problem hiding this comment.
I am a little resistant because I am hopeful we can make pii_from_doc immutable here. That should reduce the risk of a regression and render this test unnecessary.
matthinz
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10390 we started using the new
idv_session.updated_user_addressvalue to represent the user address if it is present. This allows us to stop overwriting the user address that was on the document inpii_from_doc. We were not able to actually take this step because of the 50/50 state issues related to session updates.This commit stops overwriting the PII from the document in
pii_from_docwhen a new address is provided inIdv::AddressController