Start reading from idv_session.updated_user_address#10390
Merged
Conversation
Contributor
Author
|
I meant to open this as a draft PR. This can't be merged until the changes in #10385 are merged and deployed. |
jmhooper
force-pushed
the
jmhooper-write-address-data-to-session
branch
from
d0a1ad6 to
2b0b481
Compare
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
eafe194 to
a8aa936
Compare
jmhooper
force-pushed
the
jmhooper-write-address-data-to-session
branch
from
2b0b481 to
2686118
Compare
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
a8aa936 to
e3d3054
Compare
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
e3d3054 to
8c6e8c1
Compare
jmhooper
changed the title
idv_session.updated_user_address_dataidv_session.updated_user_address
Contributor
Author
|
I merged #10385. This should be ready for review now! |
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
8c6e8c1 to
eb87593
Compare
zachmargolis
approved these changes
Apr 10, 2024
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
eb87593 to
0e31b3a
Compare
zachmargolis
approved these changes
Apr 15, 2024
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
0e31b3a to
bb308e6
Compare
In #10385 we started writing the address the user provides in the `Idv::AddressController` to `idv_session.updated_user_address_data`. This commit starts reading the address from there so that we can eventually stop overwriting the address in `pii_from_doc`. [skip changelog]
jmhooper
force-pushed
the
jmhooper-read-address-data-from-session
branch
from
77e8f30 to
38dc46c
Compare
jmhooper
added a commit
that referenced
this pull request
Apr 16, 2024
In #10390 we started using the new `idv_session.updated_user_address` value to represent the user address if it is present. This allows us to stop overwriting the user address that was on the document in `pii_from_doc`. We were not able to actually take this step because of the 50/50 state issues related to session updates. This commit stops overwriting the PII from the document in `pii_from_doc` when a new address is provided in `Idv::AddressController` [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Apr 18, 2024
In #10390 we started using the new `idv_session.updated_user_address` value to represent the user address if it is present. This allows us to stop overwriting the user address that was on the document in `pii_from_doc`. We were not able to actually take this step because of the 50/50 state issues related to session updates. This commit stops overwriting the PII from the document in `pii_from_doc` when a new address is provided in `Idv::AddressController` [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10385 we started writing the address the user provides in the
Idv::AddressControllertoidv_session.updated_user_address. This commit starts reading the address from there so that we can eventually stop overwriting the address inpii_from_doc.