Blackscreen Fix Attempt: Move Hint Text State Into a Hook#10343
Closed
Blackscreen Fix Attempt: Move Hint Text State Into a Hook#10343
Conversation
Contributor
night-jellyfish
left a comment
There was a problem hiding this comment.
I tested this out in a few ways:
- Following the instructions on this PR (all worked as expected)
- Trying to recreate the black screen and then see if I couldn't recreate it in this branch. I could recreate it in this branch, however I'm not even close to positive that the way I recreate the black screen is what is happening when a user encounters it.
I was going to approve it, but I found hint text disappeared in this branch again, even though it seems to have the fix from #10339. I did also see a lint failure (and a test failure, though I think the test is a flaky one and nothing to do with this branch).
Once the hint text and lint issues are fixed I would feel more comfortable approving.
Contributor
Author
|
I'm closing this since it's not obviously the source of the issue and it's causing issues in test. Ideally I'll revisit and move the text into a context, but that's a different PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This is an attempt to fix the blackscreen issue that users are seeing.
AcuantCaptureCanvastwice before the permissions prompt, but it does not get rerendered after the permissions prompt is accepted.maintheAcuantSelfieCaptureCanvascomponent gets rendered twice, then once more after the permissions prompt.This work removes the extra rerender of
AcuantSelfieCaptureCanvasafter the permissions prompt under the theory that something about that re-render is leading to the black screen problem.Note: This is generally a better place to keep this state, so even if it doesn't fix the bug, it still improves the codebase.
📜 Testing Plan
I don't have a way to reliably reproduce the black screen problem as users see it, but you can check that this code does in fact remove a render by:
console.log('render AcuantSelfieCaptureCanvas) to that component, under theconst { t } = useI18n();