Fix Missing Hint Text on Android - Move the hint text inside the capture div#10339
Merged
Fix Missing Hint Text on Android - Move the hint text inside the capture div#10339
Conversation
night-jellyfish
approved these changes
Mar 29, 2024
Contributor
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
Tested this out and I see hint text! 🎉 Great catch!
Contributor
Author
|
I do want to note that I think @amirbey implemented it this way before and I think I changed it in the course of other work at some point. So thanks for getting it right originally Amir 😅 |
eileen-nava
approved these changes
Mar 29, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Thanks for fixing this. 🙏🏻 I tested it on Android/Chrome and it worked well.
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR fixes an issue where the hint text was not showing on Android/Chrome by moving the hint text inside the div that the Acuant SDK binds to. Before this PR the hint text would not show up on Android/Chrome most of the time.
I've tested that the hint text appears with this PR for: