-
Notifications
You must be signed in to change notification settings - Fork 166
LG-12670: handoff ipp option #10260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-12670: handoff ipp option #10260
Changes from all commits
841a0f2
b26d41b
188a45d
be3faa3
2cd1977
95d23c1
b31b55b
4e23871
0b308b1
527e65a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,9 @@ def show | |
| @upload_disabled = idv_session.selfie_check_required && | ||
| !idv_session.desktop_selfie_test_mode_enabled? | ||
|
|
||
| @opt_in_ipp_enabled = IdentityConfig.store.in_person_doc_auth_button_enabled && | ||
| Idv::InPersonConfig.enabled_for_issuer?(decorated_sp_session.sp_issuer) | ||
|
|
||
| @selfie_required = idv_session.selfie_check_required | ||
|
|
||
| analytics.idv_doc_auth_hybrid_handoff_visited(**analytics_arguments) | ||
|
|
@@ -22,6 +25,8 @@ def show | |
| true | ||
| ) | ||
|
|
||
| # reset if we visit or come back | ||
| idv_session.skip_doc_auth_from_handoff = nil | ||
| render :show, locals: extra_view_variables | ||
| end | ||
|
|
||
|
|
@@ -42,9 +47,11 @@ def self.selected_remote(idv_session:) | |
| if IdentityConfig.store.in_person_proofing_opt_in_enabled && | ||
| IdentityConfig.store.in_person_proofing_enabled && | ||
| idv_session.service_provider&.in_person_proofing_enabled | ||
| idv_session.skip_doc_auth == false | ||
| idv_session.skip_doc_auth == false || | ||
| idv_session.skip_doc_auth_from_handoff == true | ||
|
||
| else | ||
| idv_session.skip_doc_auth.nil? || idv_session.skip_doc_auth == false | ||
| idv_session.skip_doc_auth.nil? || idv_session.skip_doc_auth == false || | ||
| idv_session.skip_doc_auth_from_handoff == true | ||
| end | ||
| end | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,6 +89,16 @@ | |
| <%= f.submit t('forms.buttons.send_link') %> | ||
| <% end %> | ||
| </div> | ||
| <% if @opt_in_ipp_enabled %> | ||
|
||
| <div class="margin-top-4 padding-top-2 border-top border-primary-light"> | ||
| <p class="margin-top-1"> | ||
| <%= t('doc_auth.info.hybrid_handoff_ipp_html') %>' | ||
| </p> | ||
| <p class="margin-top-1 margin-bottom-0"> | ||
| <%= link_to t('in_person_proofing.headings.prepare'), idv_document_capture_path(step: :hybrid_handoff) %> | ||
| </p> | ||
| </div> | ||
| <% end %> | ||
| </div> | ||
| <% end %> | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable name is confusing to me. The code in the selected_remote method is checking config values to determine if opt in IPP is enabled, however we are checking a different set of config values here. So I'm not totally sure I understand what this var is checking for? I'm also unclear on how it's being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackRyan1989 , yes it is a "general" opt in for IPP and may drift away the existing "Optin" meaning. I will rename it.