Conversation
dawei-nava
force-pushed
the
dwang/LG-12670_handoff_ipp_option
branch
from
d35b79f to
d38dd75
Compare
dawei-nava
changed the title
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Is LG-12670 the correct ticket for this work? I don't see any changes to analytics_events or anything about capturing the SDK version number. This seems more related to setting up the infrastructure to handle routing in the React app for a new feature?
There was a problem hiding this comment.
Why this addition when this check already exists on line 67?
There was a problem hiding this comment.
This variable name is confusing to me. The code in the selected_remote method is checking config values to determine if opt in IPP is enabled, however we are checking a different set of config values here. So I'm not totally sure I understand what this var is checking for? I'm also unclear on how it's being used.
There was a problem hiding this comment.
@JackRyan1989 , yes it is a "general" opt in for IPP and may drift away the existing "Optin" meaning. I will rename it.
There was a problem hiding this comment.
Why are we using this value as a precondition when it's not set to true until the document capture page?
There was a problem hiding this comment.
@JackRyan1989 , it's for the "back" button to work from document capture(IPP) page.
So the user can go from handoff (select ipp)-> document catpure -> Back -> handoff.
This is a new flag to control this behavior similar to skip_doc_auth.
There was a problem hiding this comment.
It seems like this value is referring to a new page for document capture rather than opt in IPP, so I think we should rename it.
changelog: User-Facing Improvements, Doc Auth, Allow user select IPP if available from handoff page.
dawei-nava
force-pushed
the
dwang/LG-12670_handoff_ipp_option
branch
from
28e6abd to
527e65a
Compare
2 participants
🎫 Ticket
Replaced with new PR #10267
Link to the relevant ticket:
LG-12670
🛠 Summary of changes
WIP
IPP options on hybrid handoff page when IPP is available.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Details
After:
IPP available and selfie required
IPP available and NO selfie required
IPP NOT available and Selfie required
IPP NOT available and NO Selfie required