Skip to content

LG-12122: update selfie hint text translations. #10213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dawei-nava merged 1 commit into from
Mar 11, 2024
Merged

LG-12122: update selfie hint text translations. #10213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/locales/doc_auth/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ es:
modificar su información.
selfie_capture_status:
face_close_to_border: DEMASIADO CERCA DEL MARCO
face_not_found: NO SE ENCONTRÓ LA CARA
face_too_small: LA CARA ES DEMASIADO CHICA
too_many_faces: HAY DEMASIADAS CARAS
face_not_found: NO SE DETECTÓ EL ROSTRO
Copy link
Contributor

@aduth aduth Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is existing, but wonder if your team would consider reevaluating these texts as all-caps, as it can have a number of accessibility challenges.

Nicely compiled in this comment: humanmade/hm-pattern-library#75 (comment)

Copy link
Contributor Author

@dawei-nava dawei-nava Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth , I believe we kind of discussed, these texts are to customize Acuant SDK hints, and the SDK has known issues with SDK reader, even we have normal texts. @kellular, please correct me if I am wrong.

PS. there are discussions on how to fix the screen reader issue on our side in Timnit.

On the other hand, it still make sense to use normal text to avoid additional work down the road once we fix the SDK issue.

Copy link
Contributor

@aduth aduth Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked resource includes issues with caps text beyond just screen readers.

That being said, I know it's out of scope of the ticket you're working on, just wanted to flag it for future consideration.

Copy link
Contributor Author

@dawei-nava dawei-nava Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth , I agree with your assessment, just wondering whether our designer already had kind of plan for it.

Copy link

@kellular kellular Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth @dawei-nava Hey sorry for the late reply on this, I was out sick last week!

Let's move accessibility/style updates on the hint text into a separate ticket — I will create a ticket in the backlog for us. Thank you for the resource @aduth!

face_too_small: ROSTRO DEMASIADO PEQUEÑO
too_many_faces: DEMASIADOS ROSTROS
ssn: Necesitamos su número de Seguro Social para validar su nombre, fecha de
nacimiento y dirección.
tag: Recomendado
Expand Down