Skip to content

LG-12122: update selfie hint text translations.#10213

Merged
dawei-nava merged 1 commit intomainfrom
dwang/LG-12122_selfie_hint_text
Mar 11, 2024
Merged

LG-12122: update selfie hint text translations.#10213
dawei-nava merged 1 commit intomainfrom
dwang/LG-12122_selfie_hint_text

Conversation

@dawei-nava
Copy link
Contributor

@dawei-nava dawei-nava commented Mar 7, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12122

🛠 Summary of changes

Updated with translation text for selfie hints.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: Enter selfie flow with different language preference
  • Step 2: Taking selfie with different positions
  • Step 3: Verify hint texts.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

After: Spanish

No face found
ES_NoFace

Face too small

64F47916-53B4-4212-B09A-04294757FFEA_1_201_a

Face close to border

9B4B3FEB-CA09-4FAA-8E1E-411956401416_1_201_a

French

No face
Fr-NoFace

F7B531A6-B61C-4A5D-B6D8-4278694191D2_1_201_a

changelog: User-Facing Improvements, Doc Auth, Update selfie hint text translations.
face_not_found: NO SE ENCONTRÓ LA CARA
face_too_small: LA CARA ES DEMASIADO CHICA
too_many_faces: HAY DEMASIADAS CARAS
face_not_found: NO SE DETECTÓ EL ROSTRO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is existing, but wonder if your team would consider reevaluating these texts as all-caps, as it can have a number of accessibility challenges.

Nicely compiled in this comment: humanmade/hm-pattern-library#75 (comment)

Copy link
Contributor Author

@dawei-nava dawei-nava Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth , I believe we kind of discussed, these texts are to customize Acuant SDK hints, and the SDK has known issues with SDK reader, even we have normal texts. @kellular, please correct me if I am wrong.

PS. there are discussions on how to fix the screen reader issue on our side in Timnit.

On the other hand, it still make sense to use normal text to avoid additional work down the road once we fix the SDK issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked resource includes issues with caps text beyond just screen readers.

That being said, I know it's out of scope of the ticket you're working on, just wanted to flag it for future consideration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth , I agree with your assessment, just wondering whether our designer already had kind of plan for it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth @dawei-nava Hey sorry for the late reply on this, I was out sick last week!

Let's move accessibility/style updates on the hint text into a separate ticket — I will create a ticket in the backlog for us. Thank you for the resource @aduth!

@dawei-nava dawei-nava marked this pull request as ready for review March 11, 2024 13:02
Copy link

@kellular kellular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good to me

@dawei-nava dawei-nava merged commit 173fa96 into main Mar 11, 2024
@dawei-nava dawei-nava deleted the dwang/LG-12122_selfie_hint_text branch March 11, 2024 14:37
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants