Merged
Conversation
…luded in response
charleyf
requested review from
a team and
amirbey
and removed request for
a team
app/javascript/packages/document-capture/components/acuant-capture.tsx
Outdated
Show resolved
Hide resolved
| @@ -23,6 +23,7 @@ import AcuantContext, { AcuantCaptureMode } from '../context/acuant'; | |||
| import AnalyticsContext from '../context/analytics'; | |||
Contributor
There was a problem hiding this comment.
I tested this locally with both selfie on and off. I saw mostly what's expected (and always the correct value), with a few caveats:
- I didn't see the
image addedevents have theliveness_checking_requiredfield (image clickedones did have it though). I didn't see it in front, back, or selfie added events. - I had trouble triggering the following events and so didn't test them:
Frontend: IdV: barcode warning continue clicked Frontend: IdV: barcode warning retake photos clicked Frontend: IdV: Image capture failed - I did see some additional events not listed in the PR with the field:
IdV: doc auth document_capture visited
IdV: doc auth image upload form submitted
IdV: doc auth image upload vendor submitted
IdV: doc auth image upload vendor pii validation
IdV: doc auth document_capture submitted
IdV: failed doc image resubmitted
Contributor
Author
There was a problem hiding this comment.
- I forgot to add them to the analytics 😅 fixed.
- 🤷 Seems reasonable to me. I'm comfortable merging with just automated tests for these.
- Those are coming for free since I added to the
getAddAttemptAnalyticsPayload. I think it's good to have the new property more places.
Contributor
There was a problem hiding this comment.
Thanks for fixing #1! The rest makes sense to me.
app/javascript/packages/document-capture/components/barcode-attention-warning.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/document-capture-warning.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/review-issues-step.tsx
Outdated
Show resolved
Hide resolved
night-jellyfish
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-12160
🛠 Summary of changes
This is related to a previous PR to add logging to the BE here. This PR adds
liveness_checking_requiredfield to some FE logs, specifically:📜 Testing Plan
Provide a checklist of steps to confirm the changes.
liveness_checking_requiredfield that saysfalse.liveness_checking_requiredfield that saystrue.