Skip to content

LG-12160: Add liveness_checking_required To BE Logs#10150

Merged
charleyf merged 16 commits intomainfrom
lg-12160-add-liveness-check-required-to-logs
Feb 28, 2024
Merged

LG-12160: Add liveness_checking_required To BE Logs#10150
charleyf merged 16 commits intomainfrom
lg-12160-add-liveness-check-required-to-logs

Conversation

@charleyf
Copy link
Contributor

@charleyf charleyf commented Feb 23, 2024

🎫 Ticket

https://cm-jira.usa.gov/browse/LG-12160

🛠 Summary of changes

Add liveness_checking_required field to some BE logs, specfically:

  • IdV: doc auth document_capture submitted
  • IdV: doc auth document_capture visited
  • IdV: doc auth image upload form submitted
  • IdV: doc auth image upload vendor submitted

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through the IDV process with selfie off, then review the log entries above. They should all have a liveness_checking_required field that says false.
  • Go through the IDV process with selfie on, then review the log entries above. They should all have a liveness_checking_required field that says true.

@charleyf charleyf changed the title Lg 12160 add liveness check required to logs LG-12160: Add liveness_check_required To BE Logs Feb 26, 2024
@charleyf charleyf changed the title LG-12160: Add liveness_check_required To BE Logs LG-12160: Add liveness_checking_required To BE Logs Feb 26, 2024
@charleyf charleyf marked this pull request as ready for review February 27, 2024 16:37
@charleyf charleyf requested review from a team and eileen-nava and removed request for a team February 27, 2024 16:50
@amirbey
Copy link
Contributor

amirbey commented Feb 27, 2024

thanks for adding the logging ... from my testing, it appears that IdV: doc auth image upload form submitted
and IdV: doc auth image upload vendor submitted events already log liveness_checking_required. unfortunately IdV: doc auth image upload form submitted is only tested in 1 flow in analytics_spec ☹️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the logging ... from my testing, it appears that IdV: doc auth image upload form submitted
and IdV: doc auth image upload vendor submitted events already log liveness_checking_required. unfortunately IdV: doc auth image upload form submitted is only tested in 1 flow in analytics_spec ☹️

Fixed both of those things thanks!

  • Added the missing event/step into the other flows.
  • Removed the duplicate liveness_checking_required where the response already had it.

'IdV: doc auth image upload form submitted' => {
success: true, errors: {}, submit_attempts: 1, remaining_submit_attempts: 3, user_id: user.uuid, flow_path: 'standard', front_image_fingerprint: an_instance_of(String), back_image_fingerprint: an_instance_of(String), selfie_image_fingerprint: nil, liveness_checking_required: boolean
},
'IdV: doc auth image upload vendor submitted' => hash_including(success: true, flow_path: 'standard', attention_with_barcode: false, doc_auth_result: 'Passed', liveness_checking_required: boolean),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@amirbey amirbey self-requested a review February 28, 2024 20:13
Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿
thanks for adding the vendor submitted events to the spec 🙏🏿

@charleyf charleyf merged commit d05cac6 into main Feb 28, 2024
@charleyf charleyf deleted the lg-12160-add-liveness-check-required-to-logs branch February 28, 2024 20:46
@charleyf charleyf mentioned this pull request Feb 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants