LG-12265: Stop writing to sp_session[:piv_cac_requested]#10154
Merged
Conversation
jmhooper
approved these changes
Feb 26, 2024
A previous change (ref: #10153) stopped reading from sp_session[:piv_cac_requested] and started using the result from the AuthnContextResolver instead. This change follows up by removing writes to the piv_cac_requested property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
jmhooper
force-pushed
the
dprice-lg-12265-stop-writing-piv-cac-requested
branch
from
486ceca to
6c5be30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12265
🛠 Summary of changes
A previous change (ref: #10153) stopped reading from sp_session[:piv_cac_requested] and started using the result from the AuthnContextResolver instead.
This change follows up by removing writes to the piv_cac_requested property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed.