-
Notifications
You must be signed in to change notification settings - Fork 167
LG-12372: sdk autocaptured id images route to non-cropping workflow #10131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
11e57a4
97f84ea
a765230
db49961
80ee33c
dca6e9a
0a5a48c
b36cab7
c804a9d
80ec1e1
06f07ff
bd0d1a0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,13 +12,15 @@ def initialize( | |
| back_image:, | ||
| selfie_image: nil, | ||
| image_source: nil, | ||
| images_cropped: false, | ||
| liveness_checking_required: false | ||
| ) | ||
| super(config: config, user_uuid: user_uuid, uuid_prefix: uuid_prefix) | ||
| @front_image = front_image | ||
| @back_image = back_image | ||
| @selfie_image = selfie_image | ||
| @image_source = image_source | ||
| @images_cropped = images_cropped | ||
|
||
| # when set to required, be sure to pass in selfie_image | ||
| @liveness_checking_required = liveness_checking_required | ||
| end | ||
|
|
@@ -70,7 +72,7 @@ def password | |
| end | ||
|
|
||
| def workflow | ||
| if acuant_sdk_source? | ||
| if @images_cropped | ||
| include_liveness? ? | ||
| config.trueid_liveness_nocropping_workflow : | ||
| config.trueid_noliveness_nocropping_workflow | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I don't think we need to update the AcuantClient, since we're already planning on removing it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eileen-nava - i understand that we are not currently using acuant ... however, the the post_images method is polymorphic and wherever defined I think the signature should match. if acuant will be removed in a future sprint, I am missing the downside here 🤔