LG-12372: sdk autocaptured id images route to non-cropping workflow#10131
LG-12372: sdk autocaptured id images route to non-cropping workflow#10131
Conversation
2588db7 to
e78f4a8
Compare
6f9d00c to
71e2a90
Compare
There was a problem hiding this comment.
Could you refactor this to
image_metadata.dig(:front, :acuantCaptureMode) == 'AUTO' && image_metadata.dig(:back, :acuantCaptureMode) == 'AUTO'? I'd expect that to still work, and it would have less conditional logic.
There was a problem hiding this comment.
FWIW, I don't think we need to update the AcuantClient, since we're already planning on removing it.
There was a problem hiding this comment.
@eileen-nava - i understand that we are not currently using acuant ... however, the the post_images method is polymorphic and wherever defined I think the signature should match. if acuant will be removed in a future sprint, I am missing the downside here 🤔
There was a problem hiding this comment.
Nit: Would it be worth adding an attr_reader for @images_cropped? Then you could just call images_cropped on line 75.
There was a problem hiding this comment.
@eileen-nava , if this prop not used by other classes, then I guess it's ok to use prop directly(especially not accessed multiple places in the owning class)?
There was a problem hiding this comment.
@dawei-nava Hmmm, that's a good point. It does look like front_image, back_image, selfie_image, and liveness_checking_required are all accessed once in the owning class, too.
afb64fd to
6ff8361
Compare
changelog: Internal, Document Authentication, SDK autocaptured images routed to non-cropping workflow
6ff8361 to
bd0d1a0
Compare
🎫 Ticket
LG-12372
🛠 Summary of changes
Only use TrueID cropped workflows when ID images are cropped (autocaptured via Acuant SDK)
📜 Testing Plan