Skip to content
Closed
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
07b2cbf
update fraud review concern
Jan 30, 2024
d76d05c
add contitional for use in displaying the progress bar
Jan 30, 2024
98e0979
add fraud review concern as before action
Jan 30, 2024
61b6bd5
update view to use conditional var
Jan 30, 2024
ec818bf
updating specs
Jan 31, 2024
ca553cc
trying to get please call view to conditionally hide step indicator
Jan 31, 2024
d1a0930
update concerns and checker
Feb 1, 2024
ab909b3
Confirm that the enrollment is passed in fraud review and confrim tha…
Feb 2, 2024
554e3c9
get spec to passing
Feb 2, 2024
3f491be
remove unneeded session info from spec
Feb 2, 2024
a1feb3b
edits to please call controller
Feb 5, 2024
005c19c
revising check for fraud review checker and spec
Feb 5, 2024
788adfc
changelog: User-Facing Improvements, In Person Proofing, Display plea…
Feb 5, 2024
cc17f3f
changelog: User-Facing Improvements, In Person Proofing, Display plea…
Feb 5, 2024
a1d8f15
lintfix
Feb 6, 2024
641d3aa
ready to verify spec passing
Feb 6, 2024
28f6932
Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-1199…
Feb 6, 2024
0c07122
refactor please call controller and add new user method add specs
Feb 7, 2024
ed2f2de
updated translation html and specs
Feb 7, 2024
11b902f
Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-1199…
Feb 7, 2024
e04132b
remove missing comment
Feb 7, 2024
d94b34b
remove errant octothorpe
Feb 7, 2024
113ec7d
normalize yaml
Feb 7, 2024
b514176
addressing Shannon's review
Feb 8, 2024
80f60bc
enforcing tmx flag for call to new user method to prevent issues in 5…
Feb 8, 2024
317480d
lintfix
Feb 8, 2024
d8183a0
call in_person_handle_pending_fraud_review initially and prevetn hand…
Feb 9, 2024
977bdef
enforce redirection only for passing enrollments and refactor so usua…
Feb 9, 2024
05f36b7
refactor to be more explicit and to handle enrollment statuses proper…
Feb 12, 2024
97d5b12
lintfix
Feb 12, 2024
3ca117c
use the right before action
Feb 12, 2024
d11924c
Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-1199…
Feb 12, 2024
713f5be
fix before action and page rendering expectations
Feb 12, 2024
ba0a5e5
Merge branch 'jryan/lg-11995-threatmetrix-please-call-ipp-screen' int…
Feb 13, 2024
85d76fd
Bounce out of fraud screen redirection if user has not passed ipp but…
Feb 20, 2024
b12b14b
changelog: User-Facing Improvements, In-Person Proofing, only redirec…
Feb 20, 2024
79a3855
Merge branch 'main' into jryan/lg-12172-tmx-rejection-screen
jack-ryan-nava-pbc Feb 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions app/controllers/concerns/fraud_review_concern.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ module FraudReviewConcern
delegate :fraud_check_failed?,
:fraud_review_pending?,
:fraud_rejection?,
:ipp_fraud_review_pending?,
to: :fraud_review_checker

def handle_fraud
in_person_handle_pending_fraud_review
# If the user has not passed IPP at a post office, allow them to
# complete another enrollment by not redirecting to please call
# or rejection screen
return if in_person_prevent_fraud_redirection?
handle_pending_fraud_review
handle_fraud_rejection
end
Expand All @@ -24,17 +26,9 @@ def handle_fraud_rejection
redirect_to_fraud_rejection if fraud_rejection?
end

def in_person_handle_pending_fraud_review
return unless in_person_can_perform_fraud_review?
if fraud_review_pending? && current_user.in_person_enrollment_status == 'passed'
redirect_to_fraud_review
end
end

def in_person_can_perform_fraud_review?
def in_person_prevent_fraud_redirection?
IdentityConfig.store.in_person_proofing_enforce_tmx &&
current_user.in_person_enrollment_status != 'canceled' &&
!current_user.in_person_enrollment_status.nil?
current_user.in_person_enrollment_status != 'passed'
end

def redirect_to_fraud_review
Expand Down