Render icon styles as component stylesheet#10068
Merged
Conversation
changelog: Internal, Performance, Reduce size of application stylesheet
zachmargolis
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates icon styles to be removed from the main stylesheet and rendered alongside
IconComponent.This was not done previously because there is a React component which also references these styles, and we do not currently have support for on-demand stylesheet support for React components.
However, it turns out we're not actually using the React
Iconcomponent, so this pull request removes its implementation and creates the new ViewComponent stylesheet.This will eventually complement #10065 which, if #10067 is merged, would have additional styles to be included in this stylesheet.
📜 Testing Plan
Verify no regressions in the appearance of icons, e.g.: