Render icon for mobile navigation close button#10056
Merged
Conversation
changelog: Internal, Code Quality, Remove redundant image for mobile navigation menu button
mitchellhenke
approved these changes
Feb 8, 2024
Contributor
Author
Thinking out loud a bit: This is probably true for this icon's usage, since it appears on the account page where we're using other icons. But I'm not sure the guidance holds true for replacing any ad-hoc icon with the sprite, since it may introduce the sprite download to a page where it doesn't already exist. For example, we have icons we could replace on the sign-in page (in the "Here's how you know" banner and language picker), but the sprite isn't currently being loaded on those pages, and it's about 22kb in size. Some ideas:
|
This was referenced Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates rendering of the mobile navigation menu close button icon to use
IconComponentinstead of a custom SVG.Why?
sprite.svgSVG sprite image is assumed to be cached by the time this image is displayed📜 Testing Plan
👀 Screenshots
Visual differences are expected to be very minimal.