This repository was archived by the owner on Apr 22, 2021. It is now read-only.
Add support for only checking year of birth in LexisNexis (LG-3706)#52
Merged
zachmargolis merged 3 commits intomainfrom Jan 27, 2021
Merged
Add support for only checking year of birth in LexisNexis (LG-3706)#52zachmargolis merged 3 commits intomainfrom
zachmargolis merged 3 commits intomainfrom
Conversation
stevegsa
reviewed
Jan 27, 2021
| it 'only sends the birth year to LexisNexis (extra applicant attribute)' do | ||
| expect(aamva_proofer).to receive(:proof).and_return(Proofer::Result.new) | ||
| expect(lexisnexis_proofer).to receive(:proof). | ||
| with(hash_including(dob_year_only: true)). |
Contributor
There was a problem hiding this comment.
dob_year_only: dob_year_only
mitchellhenke
approved these changes
Jan 27, 2021
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
👍🏼
I don't think the IDP would/should have any issues, but will be keeping an eye out for whether switching the order of LN -> AAMVA to AAMVA -> LN in some cases causes issues.
Contributor
Author
I agree, the ordering switch is the riskiest part of this, but I didn't see another way to accomplish the goal of the ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on: 18F/identity-lexisnexis-api-client-gem#20
dob_year_onlytop-level argument to the lambda payload bodydob_year_onlyinto LN, so that LN only sends DOBNext steps: