Skip to content

Rename project to identity-design-system, scope package to 18F#331

Merged
aduth merged 2 commits intomainfrom
aduth-rename-design-system
Apr 3, 2023
Merged

Rename project to identity-design-system, scope package to 18F#331
aduth merged 2 commits intomainfrom
aduth-rename-design-system

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 10, 2023

  • Improve discoverability for people searching for the Login.gov Design System
  • Scope package to organization to adhere to best practices

Follow-up:

  • Rename repository in GitHub repository settings.
  • Consider resetting version count to 1.0.0 in package.json

@aduth aduth requested a review from nickttng March 10, 2023 16:54
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Consider resetting version count to 1.0.0 in package.json

I think it makes sense to keep the numbers going up, because it's the same git repo with the same history

@aduth
Copy link
Contributor Author

aduth commented Mar 14, 2023

Consider resetting version count to 1.0.0 in package.json

I think it makes sense to keep the numbers going up, because it's the same git repo with the same history

Yeah, on second thought, a reset is probably not worth it. It also runs contrary to my own reluctance to accept "big major version = bad", we aren't at risk of running out of numbers.

@aduth aduth force-pushed the aduth-rename-design-system branch 2 times, most recently from 7bad8e6 to 95e1344 Compare March 14, 2023 19:40
@aduth
Copy link
Contributor Author

aduth commented Apr 3, 2023

Renaming the repository might require some more work, so I'm going to limit the changes to package references for now and merge.

@aduth aduth force-pushed the aduth-rename-design-system branch from 9de3fd3 to decd9cc Compare April 3, 2023 12:31
@aduth aduth merged commit 0cdb7f2 into main Apr 3, 2023
@aduth aduth deleted the aduth-rename-design-system branch April 3, 2023 12:38
@aduth aduth mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants