Rename project to identity-design-system, scope package to 18F#331
Merged
Rename project to identity-design-system, scope package to 18F#331
Conversation
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM
Consider resetting version count to 1.0.0 in package.json
I think it makes sense to keep the numbers going up, because it's the same git repo with the same history
zachmargolis
approved these changes
Mar 10, 2023
nickttng
approved these changes
Mar 10, 2023
Contributor
Author
Yeah, on second thought, a reset is probably not worth it. It also runs contrary to my own reluctance to accept "big major version = bad", we aren't at risk of running out of numbers. |
7bad8e6 to
95e1344
Compare
This was referenced Mar 22, 2023
Merged
Contributor
Author
|
Renaming the repository might require some more work, so I'm going to limit the changes to package references for now and merge. |
9de3fd3 to
decd9cc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up:
package.json