Conversation
aduth
force-pushed
the
aduth-uswds-3
branch
2 times, most recently
from
441aba8 to
ca745e8
Compare
|
Hm, looks like my celebration of "All checks have passed" may be premature, since it looks like the last commit didn't run in CircleCI. I'll try to see what happened. Edit: Ah, appears to be an outage: https://status.circleci.com/incidents/dcqb3fykhgvg |
|
@nickttng and I chatted about the remaining visual regression failures related to the difficulty in preserving the line-height mixin override that we had previously used to override the default design system behavior. We came to consensus that we're okay to drop this override and return to the default design system behavior. This is ready for final review. |
**Why**: - To take advantage of the latest features and bug fixes - Notably, to be able to start taking advantage of new component-based cherry-picked imports - To avoid additional maintenance burden due to version drift
Technically it still exists in USWDS, but the exports are set up in such a way that it's not reachable
Maybe temporary, at least to get visual regression tests identifying real issues
This reverts commit 914958e.
Allows for extension in downstream projects
|
I'm going to merge this to main, with follow-ups planned at #336. There's still a couple more steps before this is ready to publish, but we're getting close! Thanks @nickttng & @zachmargolis for your help with this. |
3 participants
Why: