V1.2 #7
Open
V1.2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marie Bremner <[email protected]>
…magma#2400) Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Alejandro Rodriguez <[email protected]>
This would allow multi APN GW configuration. We need to store GW info for each upstream APN network. Signed-off-by: Pravin B Shelar <[email protected]>
This patch will be used by MME to program table zero with VLAN id. This patch does not change any functionality. Signed-off-by: Pravin B Shelar <[email protected]>
…ace (magma#2343) AGW operator would like to configure vlan tag for SGi interface for management interface. This mconfig could allow them to configure it via orc8r API Signed-off-by: Pravin B Shelar <[email protected]>
…agma#2405) Signed-off-by: Alejandro Rodriguez <[email protected]>
AGW operator would like to configure vlan tag for SGi interface for management interface. This allows to set vlan tag for the SGi interface using pipelineD config Signed-off-by: Pravin B Shelar <[email protected]>
Signed-off-by: Karthik Subraveti <[email protected]>
Signed-off-by: Benno Joy <[email protected]>
…a#2410) * Adding persist_state_enabled check for s1ap_imsi_map read/write operations Signed-off-by: Alejandro Rodriguez <[email protected]> * Renaming put_s1ap_imsi_map to write_s1ap_imsi_map_to_db Signed-off-by: Alejandro Rodriguez <[email protected]>
In Multi APN configuration, we support configuring VLAN-id for each APN. This patch adds support for setting vlan id to uplink flow. Eventually this functionality would be moved to pipelined. Signed-off-by: Pravin B Shelar <[email protected]>
- Remove v2 tab labels - add one more step of 3 hour window for custom metrics Signed-off-by: Karthik Subraveti <[email protected]>
Signed-off-by: Shruti Sanadhya <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
This reverts commit 3641b10. Signed-off-by: Karthik Subraveti <[email protected]>
Signed-off-by: Nick Yurchenko <[email protected]>
… enb ip allocation (magma#2432) Signed-off-by: Alejandro Rodriguez <[email protected]>
Signed-off-by: mgermano <[email protected]>
Signed-off-by: mgermano <[email protected]>
This patch fixes couple of issues. 1. Fix patch corruption the resulted from "Update copyright" patch 2. Use xnet=false to avoid resetting pkt-mark Signed-off-by: Pravin B Shelar <[email protected]>
* Free common procedure after failure notif Signed-off-by: Shruti Sanadhya <[email protected]> * Add test case for Auth failure due to MAC failure Signed-off-by: Shruti Sanadhya <[email protected]>
Signed-off-by: Hunter Gatewood <[email protected]>
Signed-off-by: Karthik Subraveti <[email protected]>
GTP patches are updates to OVS 2.14, This allows up to get rid of bunch of patches that were backported from OVS master for supporting kernel 5.6. This is based of commit 42f667e223c005683185a97dd092545d27f29a04 from branch-2.14. This patch also remove support for OVS 2.9 and 2.13 which is not going to be supported. Signed-off-by: Pravin B Shelar <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Nick Yurchenko <[email protected]>
upstream OVS has different GTP header field names. This patch uses them to avoid error on such OVS with GTP end marker support. We will not be using older OVS packages so there is no need to maintain any compatibility. This patch also adds event logging, That would be useful for debugging of-connection related issues. Signed-off-by: Pravin B Shelar <[email protected]>
This API need to take ip adddress CIDR to set subnet mask on AGW. Signed-off-by: Pravin B Shelar <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
Signed-off-by: Karthik Subraveti <[email protected]>
…magma#2702) Signed-off-by: Hunter Gatewood <[email protected]>
Signed-off-by: Timothée Dzik <[email protected]>
Signed-off-by: Marie Bremner <[email protected]>
…magma#2722) Signed-off-by: Hunter Gatewood <[email protected]>
Signed-off-by: Timothée Dzik <[email protected]>
Signed-off-by: Timothée Dzik <[email protected]>
Signed-off-by: Jacky Tian <[email protected]>
|
demo_test |
11 similar comments
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
demo_test |
|
Can one of the admins verify this patch? |
119Vik
pushed a commit
that referenced
this pull request
Dec 2, 2020
* Add T3489 tests
Introduce a new test to validate T3489 expiry.
Credit to ulaskozat for the diff
Testing done:
Verified that an ASAN use after free occurs on timer expiry
=7031==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000093460 at pc 0x555807545462 bp 0x7f87093fd2b0 sp 0x7f87093fd2a8
WRITE of size 8 at 0x603000093460 thread T16
#0 0x555807545461 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:101
#1 0x5558075c47c5 in esm_proc_esm_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:119
#2 0x55580759339b in esm_recv_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_recv.c:575
#3 0x555807551fba in _esm_sap_recv /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:679
#4 0x555807550f33 in esm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:283
#5 0x5558075195a0 in lowerlayer_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/LowerLayer.c:276
#6 0x55580757848f in _emm_as_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:688
#7 0x555807574ec4 in emm_as_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:180
#8 0x55580753147f in emm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_sap.c:105
#9 0x5558074d74fc in nas_proc_ul_transfer_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/nas_proc.c:326
#10 0x5558071bd634 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:97
#11 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
#12 0x5558071bf169 in mme_app_thread /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:447
#13 0x7f871e11f4a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x74a3)
#14 0x7f871a494d0e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xe8d0e)
0x603000093460 is located 0 bytes inside of 32-byte region [0x603000093460,0x603000093480)
freed by thread T16 here:
#0 0x7f871e602a10 in free (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1a10)
#1 0x5558070dc054 in free_wrapper /home/vagrant/magma/lte/gateway/c/oai/common/dynamic_memory_check.c:47
#2 0x555807545496 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:103
#3 0x5558075c517a in _esm_information /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:269
#4 0x5558075c4e15 in _esm_information_t3489_handler /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:199
#5 0x5558074e2e8a in mme_app_nas_timer_handle_signal_expiry /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/util/nas_timer.c:100
#6 0x5558071be2d2 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:235
#7 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
Signed-off-by: Amar Padmanabhan <[email protected]>
* Invalidate the T3849 timer id while processing esm information retransmit
The _esm_information function stops the existing T3849 timer as referenced
by the esm_ctxt datastructure timer before rescheduling a new T3849 timer
when it requests for the esm info from a UE.
Stopping the timer has a side effect of freeing up the UE related
retransmission data associated with it. This causes issues during
the T3849 timer expiry handling as the cancelled timer and the rescheduled
one reuse the same retransmission data datastructure.
Fix this by unsetting the T3849 timer in the handling of the timer expiry
as the esm_ctxt is not associated with any valid timers anymore. Further
as the timer is a oneshot timer it will be cleaned up after the processing
of the timer callback.
Signed-off-by: Amar Padmanabhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information