Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-react from 7.20.5 to 7.21.0 in /nms/app #10

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Sep 23, 2020

Bumps eslint-plugin-react from 7.20.5 to 7.21.0.

Changelog

Sourced from eslint-plugin-react's changelog.

[7.21.0] - 2020.09.22

Added

Fixed

  • [function-component-definition]: ignore object properties (#2771[] @stefan-wullems)
  • [forbid-component-props]: Implemented support for "namespaced" components (#2767[] @mnn)
  • [prefer-read-only-props]: support Flow $ReadOnly (#2772[], #2779[], #2770[] @karolina-benitez)
  • [jsx-handler-names]: handle whitespace (#2789[] @AriPerkkio)
  • [prop-types]: Detect TypeScript types for destructured default prop values (#2780[] @sunghyunjo)
  • [jsx-pascal-case]: Handle single character namespaced component (#2791[] @daviferreira)
  • [jsx-closing-bracket-location]: In tag-aligned, made a distinction between tabs and spaces (#2796[] @Moong0122)
  • [jsx-handler-names]: false positive when handler name begins with number (#1689[] @jsphstls)
  • [prop-types]: Detect JSX returned by sequential expression (#2801[] @mikol)
  • [jsx-props-no-multi-spaces]: "Expected no line gap between" false positive (#2792[] @karolina-benitez)
  • [no-unknown-property]: check attributes with any input case (#2790[] @julienw)
  • [prop-types]/[no-unused-prop-types]: handle CallExpression in ReturnType (#2802[] @hank121314)
  • [jsx-uses-react]: mark fragment variables as used (#2775[] @remcohaszing)
  • [no-unused-prop-types]: improve component declared props detection (#2755[] @jzabala)
  • [jsx-props-no-multi-spaces]: Show error in multi-line props (#2756[] @iiison)

Changed

#2802: yannickcr/eslint-plugin-react#2802 #2801: yannickcr/eslint-plugin-react#2801 #2799: yannickcr/eslint-plugin-react#2799 #2796: yannickcr/eslint-plugin-react#2796 #2792: yannickcr/eslint-plugin-react#2792 #2791: yannickcr/eslint-plugin-react#2791 #2790: yannickcr/eslint-plugin-react#2790 #2789: yannickcr/eslint-plugin-react#2789 #2782: yannickcr/eslint-plugin-react#2782 #2780: yannickcr/eslint-plugin-react#2780 #2779: yannickcr/eslint-plugin-react#2779 #2775: yannickcr/eslint-plugin-react#2775 #2772: yannickcr/eslint-plugin-react#2772 #2771: yannickcr/eslint-plugin-react#2771 #2770: yannickcr/eslint-plugin-react#2770 #2767: yannickcr/eslint-plugin-react#2767 #2761: yannickcr/eslint-plugin-react#2761 #2757: yannickcr/eslint-plugin-react#2757 #2756: yannickcr/eslint-plugin-react#2756 #2748: yannickcr/eslint-plugin-react#2748

... (truncated)

Commits
  • 0c412ef Update CHANGELOG and bump version
  • 3c46ddf [meta] add missing unreleased changelog entries
  • 22cc878 [Fix] prop-types/no-unused-prop-types: handle CallExpression in ReturnType
  • 4da7451 [Fix] no-unknown-property: check attributes with any input case
  • facb65b [Fix] jsx-props-no-multi-spaces: "Expected no line gap between" false positive
  • 08eda7a [Tests] jsx-one-expression-per-line: add passing tests.
  • 74c4eed [Fix] prop-types: Detect JSX returned by sequential expression
  • 2bf24b2 [meta] add missing changelog entry
  • ac49944 [Fix] jsx-handler-names: false positive when handler name begins with number
  • 153eac8 [New] jsx-no-literals: add noAttributeStrings option
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 23, 2020
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Sep 29, 2020

Superseded by #11.

@dependabot dependabot bot closed this Sep 29, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nms/app/eslint-plugin-react-7.21.0 branch September 29, 2020 06:13
119Vik pushed a commit that referenced this pull request Dec 2, 2020
* Add T3489 tests

Introduce a new test to validate T3489 expiry.

Credit to ulaskozat for the diff

Testing done:
Verified that an ASAN use after free occurs on timer expiry

=7031==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000093460 at pc 0x555807545462 bp 0x7f87093fd2b0 sp 0x7f87093fd2a8
WRITE of size 8 at 0x603000093460 thread T16
    #0 0x555807545461 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:101
    #1 0x5558075c47c5 in esm_proc_esm_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:119
    #2 0x55580759339b in esm_recv_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_recv.c:575
    #3 0x555807551fba in _esm_sap_recv /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:679
    #4 0x555807550f33 in esm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:283
    #5 0x5558075195a0 in lowerlayer_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/LowerLayer.c:276
    #6 0x55580757848f in _emm_as_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:688
    #7 0x555807574ec4 in emm_as_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:180
    #8 0x55580753147f in emm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_sap.c:105
    #9 0x5558074d74fc in nas_proc_ul_transfer_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/nas_proc.c:326
    #10 0x5558071bd634 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:97
    #11 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
    #12 0x5558071bf169 in mme_app_thread /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:447
    #13 0x7f871e11f4a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x74a3)
    #14 0x7f871a494d0e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xe8d0e)

0x603000093460 is located 0 bytes inside of 32-byte region [0x603000093460,0x603000093480)
freed by thread T16 here:
    #0 0x7f871e602a10 in free (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1a10)
    #1 0x5558070dc054 in free_wrapper /home/vagrant/magma/lte/gateway/c/oai/common/dynamic_memory_check.c:47
    #2 0x555807545496 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:103
    #3 0x5558075c517a in _esm_information /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:269
    #4 0x5558075c4e15 in _esm_information_t3489_handler /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:199
    #5 0x5558074e2e8a in mme_app_nas_timer_handle_signal_expiry /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/util/nas_timer.c:100
    #6 0x5558071be2d2 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:235
    #7 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)

Signed-off-by: Amar Padmanabhan <[email protected]>

* Invalidate the T3849 timer id while processing esm information retransmit

The _esm_information function stops the existing T3849 timer as referenced
by the esm_ctxt datastructure timer before rescheduling a new T3849 timer
when it requests for the esm info from a UE.
Stopping the timer has a side effect of freeing up the UE related
retransmission data associated with it. This causes issues during
the T3849 timer expiry handling as the cancelled timer and the rescheduled
one reuse the same retransmission data datastructure.

Fix this by unsetting the T3849 timer in the handling of the timer expiry
as the esm_ctxt is not associated with any valid timers anymore. Further
as the timer is a oneshot timer it will be cleaned up after the processing
of the timer callback.

Signed-off-by: Amar Padmanabhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants