Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't open the detailed view if button is disabled #372

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix: Don't open the detailed view if button is disabled #372

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2705a86
Fix: Dont open the detailed view if button is disabled
burhandodhy Feb 5, 2024
4ed9f2d
Replace a tag with button
burhandodhy Feb 6, 2024
62c3df2
Merge branch 'develop' into fix/345
burhandodhy Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions includes/admin/class-bc-templates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,8 @@ class="brightcove-datetime brightcove-end-date"
<# } #>
</div>
<div class="media-actions">
<a href="#" class="button media-button brightcove edit"><?php esc_html_e( 'Edit', 'brightcove' ); ?></a>
<a href="#" class="button media-button brightcove preview"><?php esc_html_e( 'Preview', 'brightcove' ); ?></a>
<button class="button media-button brightcove edit"><?php esc_html_e( 'Edit', 'brightcove' ); ?></button>
<button class="button media-button brightcove preview"><?php esc_html_e( 'Preview', 'brightcove' ); ?></button>
</div>
</div>
</script>
Expand Down Expand Up @@ -724,14 +724,14 @@ class="brightcove-datetime brightcove-end-date"

<div class="media-actions">
<# if ('preview' === data.detailsMode) { #>
<a href="#" class="button media-button brightcove back"><?php esc_html_e( 'Back', 'brightcove' ); ?></a>
<button class="button media-button brightcove back"><?php esc_html_e( 'Back', 'brightcove' ); ?></button>
<# } else { #>
<# if ( data.images && data.images.thumbnail && data.images.thumbnail.src ) { #>
<a href="#" class="button media-button brightcove edit"><?php esc_html_e( 'Edit', 'brightcove' ); ?></a>
<a href="#" class="button media-button brightcove preview"><?php esc_html_e( 'Preview', 'brightcove' ); ?></a>
<button class="button media-button brightcove edit"><?php esc_html_e( 'Edit', 'brightcove' ); ?></button>
<button class="button media-button brightcove preview"><?php esc_html_e( 'Preview', 'brightcove' ); ?></button>
<# } else { #>
<a href="#" class="button media-button brightcove edit" disabled><?php esc_html_e( 'Edit', 'brightcove' ); ?></a>
<a href="#" class="button media-button brightcove preview" disabled><?php esc_html_e( 'Preview', 'brightcove' ); ?></a>
<button class="button media-button brightcove edit" disabled><?php esc_html_e( 'Edit', 'brightcove' ); ?></button>
<button class="button media-button brightcove preview" disabled><?php esc_html_e( 'Preview', 'brightcove' ); ?></button>
<# } #>
<# } #>
</div>
Expand Down
Loading