Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't open the detailed view if button is disabled #372

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

burhandodhy
Copy link
Collaborator

@burhandodhy burhandodhy commented Feb 5, 2024

Description of the Change

Closes #345

How to test the Change

  1. Clicking on a video and then on "Edit" open the video details to be edited. The only way to go back is to scroll down to the bottom and click "Back". Hitting "Back" on the browser or reloading the page has an unexpected behavior.
  2. Clicking on "Edit" on an Inactive video goes to a blank page.
Gravando.2023-10-22.172216.1.mp4

Changelog Entry

Fixed - Clicking on the "Edit" and "Preview" buttons for the inactive videos breakes the layout

Credits

Props @burhandodhy @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

felipeelia
felipeelia previously approved these changes Feb 5, 2024
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have to apply the same in assets/js/src/views/media.js as well, @burhandodhy?

@burhandodhy burhandodhy merged commit d196f1d into develop Feb 7, 2024
11 checks passed
@burhandodhy burhandodhy deleted the fix/345 branch February 7, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Videos page and navigation
2 participants