[TECH] Passage de PixCertif vers Ember Octane (3.15) #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-bergoens
commented
Jan 15, 2020
laura-bergoens
force-pushed
the
tech-pix-certif-to-ember-octane
branch
from
2de0421
to
ed7e9e7
Compare
laura-bergoens
added
👀 Func Review Needed
team-certif
👀 Tech Review Needed
and removed
Development in progress
labels
|
Yeah ! Je voulais le faire sur |
jbuget
suggested changes
Jan 18, 2020
certif/app/components/routes/authenticated/sessions/details-item.js
Outdated
Show resolved
Hide resolved
certif/app/components/routes/authenticated/sessions/list-items.hbs
Outdated
Show resolved
Hide resolved
certif/app/components/routes/authenticated/sessions/new-item.hbs
Outdated
Show resolved
Hide resolved
certif/app/components/routes/authenticated/sessions/new-item.js
Outdated
Show resolved
Hide resolved
certif/tests/unit/components/routes/authenticated/sessions/details-item-test.js
Outdated
Show resolved
Hide resolved
...s/unit/components/routes/authenticated/sessions/details/certification-candidates-tab-test.js
Outdated
Show resolved
Hide resolved
certif/tests/unit/components/routes/authenticated/sessions/details/parameters-tab-test.js
Outdated
Show resolved
Hide resolved
certif/tests/unit/components/routes/authenticated/sessions/new-item-test.js
Outdated
Show resolved
Hide resolved
laura-bergoens
force-pushed
the
tech-pix-certif-to-ember-octane
branch
from
ed7e9e7
to
8f3453d
Compare
|
I'm deploying this PR to these urls:
Please check it out! |
asrodride
reviewed
Jan 21, 2020
There was a problem hiding this comment.
@laura-bergoens comme vu ensemble :
- les notifications ne s'affichent plus sous IE 11
- le numéro de certif sur la page de finalisation de session n'est pas retranscrit correctement : je vois 10000000 sur la certif du candidat
Alors que sur la page de finalisation de session, je vois 1
laura-bergoens
commented
Jan 21, 2020
laura-bergoens
commented
Jan 21, 2020
laura-bergoens
commented
Jan 21, 2020
laura-bergoens
commented
Jan 21, 2020
certif/app/components/session-finalization-candidates-informations-step.js
Outdated
Show resolved
Hide resolved
laura-bergoens
commented
Jan 21, 2020
laura-bergoens
force-pushed
the
tech-pix-certif-to-ember-octane
branch
from
1ca2b47
to
91c0fc1
Compare
asrodride
approved these changes
Jan 22, 2020
asrodride
added
Func Review OK
laura-bergoens
force-pushed
the
tech-pix-certif-to-ember-octane
branch
from
91c0fc1
to
5beca80
Compare
added 4 commits
January 23, 2020 17:59
Just the minimum necessary to pass all tests, except for linter
Except for the ApplicationAdapter, which has a specific mixin mechanism with ember-simple-auth
added 16 commits
January 23, 2020 17:59
Except for the routes with mixin from ember-simple-auth
See : https://github.com/emberjs/rfcs/blob/master/text/0481-component-templates-co-location.md It's recommended now to colocate component with their template.
Correcting new syntax in component templates, and turning ember component into glimmer component
We have this weird habbit to create a component that will wrap the template we want to render for a route. This is too bad cause it causes an indirection (and more files created). We can directly define this template and its behaviour at the route level.
Ember community is emphasizing on applying Data-Down, Actions Up pattern. It means that a child component cannot alter a data coming from a parent component. It's also known as unidirectional data flow. We are re-enforcing this pattern at some places where we were altering objects that come from top levels
Wrapping the app is now useless since this RFC from Ember, for more explanation : emberjs/rfcs#280
NotificationsContainer component was already present is parent HBS, so it was redundant
ember-cli-notifications, to its latest version, introduces changes on its CSS. More specifically, it now uses the var() property in CSS. Unfortunately, this property is not supported by IE. Solution for now : we first left an issue on their repo to ask whether or not they plan to support IE soon, and we added a specific css to override native component css for IE
laura-bergoens
force-pushed
the
tech-pix-certif-to-ember-octane
branch
from
5beca80
to
3a34c38
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Ember est officiellement passé sur sa version Octane, avec ses changements de syntaxe, de styles, de procédés, etc...
Ils font ça doucement mais sûrement, et le code se déprécie au fur et à mesure des releases.
Prenons le rythme et transformons PixCertif en une appli Ember Octane
🤖 Solution
J'ai suivi le guide d'upgrade d'Ember vers 3.15. C'est pourquoi le premier commit contient toutes les modifs de package[-lock] nécessaires + quelques modifs à la volée pour faire dans un premier temps passer les tests au vert (sauf les tests de lint, le passage en 3.15 est assez bouleversant !).
Ensuite, j'ai pris un dossier par commit, et refacto le contenu en style Octane.
Normalement chaque commit passe les tests (sauf les premiers commits qui ne passent pas le linter).
Venez-me voir si vous voulez un digest des changements ! 😺
En gros, ce que vous allez voir de façon récurrente :
model.get('attr')oumodel.set('attr', value), maintenant c'est à la JSmodel.attr = value!🌈 Remarques
On utilise le composant ember-cli-notifications pour les notifs. On était en version 4.3.3 jusqu'à présent. Le truc c'est que cette version ne marche plus avec Octane, donc on a aussi monté la version du composant jusqu'à sa latest (à savoir 6.0.0). AUTRE problème suite à ça, le composant ne s'affiche plus sous IE (une histoire de css incompatible avec IE, voir @Krysthalia pour + d'info).
Du coup, la solution en attendant en deux temps :