[TECH] Mise à jour de PixAPP vers Ember v3.15 (PF-1034). #1025

sbedeau · 2020-01-31T16:10:00Z

🦄 Problème

Pas à jour

🤖 Solution

À jour en exécutant les code-mods.

📚 Littérature utilisée

☝️ Remarques

Compte tenu de la complexité de la montée de version, on assume exceptionnellement le fait que tous les commits ne soient pas tous verts. Cette décision est prise pour faciliter la revue.
Compte tenu de la complexité et du volume à traiter, l'objectif de cette PR est de rendre Mon-Pix compatible avec Ember v3.15. Par conséquent, seules les nouvelles pratiques nécessaires à la viabilité du produit sont abordées ici.
Les autres recommandations (passage intégral à glimmer, classes en native JS, etc.) seront implémentées dans d'autres PRs dédiées ou diluées dans les stories (fonction d'une décision à prendre)

⚠️ Pour valider

Compte tenu de la criticité associée à cette PR, on aimerait sécuriser avec

au moins 6 coches tech
au moins 2 coches func

pix-service · 2020-01-31T16:22:09Z

I'm deploying this PR to these urls:

App: https://app-pr1025.review.pix.fr
Orga: https://orga-pr1025.review.pix.fr
Certif: https://certif-pr1025.review.pix.fr
Admin: https://admin-pr1025.review.pix.fr
API: https://api-pr1025.review.pix.fr/api/

Please check it out!

mon-pix/app/adapters/user.js

mon-pix/app/templates/components/reset-password-form.hbs

mon-pix/app/templates/components/challenge-item-qcm.hbs

mon-pix/app/templates/components/challenge-embed-simulator.hbs

jbuget · 2020-02-14T08:00:56Z

Je conseille aussi cette lecture ~ https://guides.emberjs.com/release/upgrading/current-edition/

jbuget

Attention aux icones FaIcon ! https://github.com/FortAwesome/ember-fontawesome#template

J'ai surtout des questions.

Je crois avoir détecté des erreurs d'inattention (ou d'incompréhension de ma part).

A part ça, bravo pour tout le boulot abattu !

mon-pix/app/adapters/user.js

mon-pix/app/components/routes/register-form.js

mon-pix/app/templates/components/challenge-embed-simulator.hbs

mon-pix/app/templates/components/challenge-illustration.hbs

mon-pix/app/templates/components/challenge-item-qcm.hbs

mon-pix/app/templates/components/routes/register-form.hbs

mon-pix/config/optional-features.json

lisequesnel · 2020-02-14T10:13:49Z

mon-pix/package.json

@@ -81,7 +81,7 @@
    "ember-mocha": "^0.16.2",
    "ember-modal-dialog": "^2.4.4",
    "ember-moment": "^8.0.0",
-    "ember-page-title": "^5.1.0",
+    "ember-page-title": "^5.2.0",


du coup on enlève les titres ? Ya une stratégie pour les remettre après ?

ah non, je viens de comprendre, la nouvelle version 5.2.0 permet de plus hacker le truc, c'est ça ?

Je crois 🤔
@celineung ?

Non on enlève pas les titres, les titres ne marchaient plus avec la montée de version.
head.hbs est un fichier utilisé par ember-page-title lorsqu'il est en mode fastboot, sauf que nous ne l'utilisons plus en fastboot. En supprimant ce fichier, on se rend compte que les titres marchent à nouveau.
La montée de version ici est juste pour mettre le package .json à jour. Cela n'influe pas sur la correction du bug rencontré.

lisequesnel

J'ai une 500 sur la route POST student-dependent-users lorsqu'on essaie de se créer un compte après la pré-réconciliation

As an example, @ is used when data comes from a parent and this.stuff is used when stuff is retrieve or computed inside the component. See the following links for details: https://ember-learn.github.io/ember-octane-vs-classic-cheat-sheet/

Ember now refuse to find a model object of type <a> by id and retrieve an object from a different type <b> with another id. To fix this, we transformed the findRecord to a queryRecord with an adapter in order to retrieve an object of type <user> and not a fake <password-reset-demand> that is, in fact, of type <user>. Note that a findRecord is supposed to find a record thanks to an id while a queryRecord is more free in its research

Vu avec elle directement

sbedeau added Development in progress team-evaluation PR relatives à l'expérience d'évaluation labels Jan 31, 2020

sbedeau self-assigned this Jan 31, 2020

sbedeau force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch 3 times, most recently from 5b70eb1 to 0120198 Compare February 6, 2020 13:33

MelanieMEB force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from 69de7c8 to f6e0085 Compare February 6, 2020 15:42

celineung force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch 4 times, most recently from cdc0a49 to a3ac52f Compare February 11, 2020 10:03

MelanieMEB added 👀 Func Review Needed 👀 Tech Review Needed and removed Development in progress labels Feb 11, 2020

sbedeau marked this pull request as ready for review February 12, 2020 10:12

sbedeau force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from 405327c to 5d9556b Compare February 13, 2020 09:56

MelanieMEB approved these changes Feb 13, 2020

View reviewed changes

mon-pix/app/adapters/user.js Outdated Show resolved Hide resolved

chrc reviewed Feb 13, 2020

View reviewed changes

mon-pix/app/templates/components/reset-password-form.hbs Outdated Show resolved Hide resolved

chrc reviewed Feb 13, 2020

View reviewed changes

mon-pix/app/templates/components/challenge-item-qcm.hbs Outdated Show resolved Hide resolved

sbedeau added team-acces team-certif team-prescription labels Feb 13, 2020

HEYGUL approved these changes Feb 13, 2020

View reviewed changes

MathieuGilet reviewed Feb 13, 2020

View reviewed changes

mon-pix/app/templates/components/challenge-embed-simulator.hbs Outdated Show resolved Hide resolved

MathieuGilet approved these changes Feb 13, 2020

View reviewed changes

VincentHardouin approved these changes Feb 13, 2020

View reviewed changes

sbedeau force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from 5d9556b to 2c75534 Compare February 13, 2020 17:59

jbuget suggested changes Feb 14, 2020

View reviewed changes

lisequesnel reviewed Feb 14, 2020

View reviewed changes

jbuget approved these changes Feb 14, 2020

View reviewed changes

sbedeau added Tech Review OK and removed 👀 Tech Review Needed labels Feb 14, 2020

lisequesnel previously requested changes Feb 14, 2020

View reviewed changes

sbedeau requested a review from lisequesnel February 14, 2020 14:07

sbedeau force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from fd9fffe to 96d0977 Compare February 14, 2020 14:32

laura-bergoens force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from 96d0977 to 41cd2b2 Compare February 17, 2020 15:00

PhilippineLoison added the Func Review OK PO validated functionally the PR label Feb 17, 2020

asrodride self-requested a review February 17, 2020 16:54

asrodride approved these changes Feb 17, 2020

View reviewed changes

estellelandry approved these changes Feb 17, 2020

View reviewed changes

ebarbier self-requested a review February 17, 2020 17:10

ebarbier removed the 👀 Func Review Needed label Feb 17, 2020

ebarbier approved these changes Feb 17, 2020

View reviewed changes

sbedeau force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from 41cd2b2 to 8f612c9 Compare February 17, 2020 17:44

sbedeau and others added 10 commits February 18, 2020 10:24

Upgrade PixAPP to 3.15

9c8ae57

Handle new data pointing rules added by Octane.

f2e03c9

As an example, @ is used when data comes from a parent and this.stuff is used when stuff is retrieve or computed inside the component. See the following links for details: https://ember-learn.github.io/ember-octane-vs-classic-cheat-sheet/

Fix hbs using either this or @

8f3c9de

Fix student-dependant-user

075f19e

Fix page titles

95d3134

Fix reset password input form behavior

b5ca4d7

Set more arguments as this or @ in components

e4b6c2c

Rename Fa-Icon as FaIcon following norms

b55a4a5

Fix /student-dependent-users 500 on call

0a9ff30

sbedeau force-pushed the tech-upgrade-pixapp-to-ember-3.15 branch from 8f612c9 to 0a9ff30 Compare February 18, 2020 09:25

sbedeau merged commit 339476d into dev Feb 18, 2020

sbedeau deleted the tech-upgrade-pixapp-to-ember-3.15 branch February 18, 2020 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TECH] Mise à jour de PixAPP vers Ember v3.15 (PF-1034). #1025

[TECH] Mise à jour de PixAPP vers Ember v3.15 (PF-1034). #1025

sbedeau commented Jan 31, 2020 •

edited

Loading

pix-service commented Jan 31, 2020

jbuget commented Feb 14, 2020

jbuget left a comment

lisequesnel Feb 14, 2020

lisequesnel Feb 14, 2020

sbedeau Feb 14, 2020

celineung Feb 14, 2020

lisequesnel left a comment

[TECH] Mise à jour de PixAPP vers Ember v3.15 (PF-1034). #1025

[TECH] Mise à jour de PixAPP vers Ember v3.15 (PF-1034). #1025

Conversation

sbedeau commented Jan 31, 2020 • edited Loading

🦄 Problème

🤖 Solution

📚 Littérature utilisée

☝️ Remarques

⚠️ Pour valider

pix-service commented Jan 31, 2020

jbuget commented Feb 14, 2020

jbuget left a comment

Choose a reason for hiding this comment

lisequesnel Feb 14, 2020

Choose a reason for hiding this comment

lisequesnel Feb 14, 2020

Choose a reason for hiding this comment

sbedeau Feb 14, 2020

Choose a reason for hiding this comment

celineung Feb 14, 2020

Choose a reason for hiding this comment

lisequesnel left a comment

Choose a reason for hiding this comment

sbedeau commented Jan 31, 2020 •

edited

Loading