[FEATURE] Mettre à jour le contenu de l'email "Création de compte" (PIX-12924) #9417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
er-lim
force-pushed
the
pix-12924-update-pix-account-creation-email-content
branch
from
959e7af
to
fd57837
Compare
bpetetot
force-pushed
the
pix-12924-update-pix-account-creation-email-content
branch
2 times, most recently
from
647d111
to
a617691
Compare
bpetetot
force-pushed
the
pix-12924-update-pix-account-creation-email-content
branch
4 times, most recently
from
4c053ce
to
c075def
Compare
bpetetot
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
mariannebost
approved these changes
Jul 11, 2024
api/translations/en.json
Outdated
| "helpdeskLinkLabel": "here", | ||
| "moreOn": "More on", | ||
| "pixPresentation": "Pix is the online public service to assess, develop and certify your digital skills.", | ||
| "subtitle": "You can now start testing your skills." | ||
| "subtitle": "Thank you for creating your account. There is one last step to secure your account: validating your email address.", | ||
| "subtitleDescription": "It is very simple, please click on the button below and login to your Pix account." |
There was a problem hiding this comment.
C"est juste un détail mais pourquoi pas juste description je trouve ca un peu bizarre que se soit la description du sous titre 🤔
EmmanuelleBonnemay
approved these changes
Jul 11, 2024
bpetetot
added
Tech Review OK
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-12924-update-pix-account-creation-email-content
branch
2 times, most recently
from
527c472
to
7cd42ce
Compare
pix-service-auto-merge
force-pushed
the
pix-12924-update-pix-account-creation-email-content
branch
from
7cd42ce
to
0d8d6a1
Compare
pix-service-auto-merge
deleted the
pix-12924-update-pix-account-creation-email-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Contexte
Inciter l’utilisateur ayant reçu cet email à cliquer sur le bouton pour valider son adresse email lorsqu'il reçoit le mail de création de son compte.
pix-account-creation-email.params.subtitleDescription) et faire la traduction en nl et es.🤖 Proposition
fr,en,nletespour les paramètres du template d'email de création de compte.pix-account-creation-email.params.titlepour avoir un clé dynamique avec le prénom de l'utilisateur.🌈 Remarques
subtitleDescriptioncorrespondant à la clé de traductionpix-account-creation-email.params.subtitleDescription🫡 Scout rules
En voulant comprendre la configuration et l'intégration i18n dans HAPI, je me suis rendu compte qu'il n'y avait aucun tests dessus, j'ai donc ajouté des tests d'intégration de la config
i18net du pluginhapi-i18n.💯 Pour tester