feat: add expiration delta to TransactionRequest
#553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomyrd
force-pushed
the
tomyrd-transaction-request-expiration
branch
2 times, most recently
from
406d26c to
802790c
Compare
tomyrd
force-pushed
the
tomyrd-transaction-request-expiration
branch
from
802790c to
eea774c
Compare
tomyrd
force-pushed
the
tomyrd-transaction-request-expiration
branch
from
eea774c to
b5c3ac4
Compare
SantiagoPittella
approved these changes
Oct 24, 2024
CHANGELOG.md
Outdated
| * [BREAKING] Refactored `OutputNoteRecord` to use states and transitions for updates (#551). | ||
| * Added better error handling for WASM sync state | ||
| * Added better error handling for WASM sync state |
There was a problem hiding this comment.
Since we are already touching this line, would you mind adding the final dot?
bobbinth
reviewed
Oct 24, 2024
bobbinth
reviewed
Oct 24, 2024
bobbinth
reviewed
Oct 24, 2024
bobbinth
reviewed
Oct 24, 2024
tomyrd
force-pushed
the
tomyrd-transaction-request-expiration
branch
from
9483955 to
6ccf59b
Compare
bobbinth
approved these changes
Oct 25, 2024
julian-demox
pushed a commit
to demox-labs/miden-client
that referenced
this pull request
Oct 30, 2024
* feat: add transaction expiration delta to `TransactionScriptBuilder` * feat: add transaction expiration delta to `TransactionRequest` * feat: add unit test * testing fix * fix: rename procedure * chore: updage CHANGELOG * fix: address suggestions * fix: doc comments
igamigo
pushed a commit
that referenced
this pull request
Nov 7, 2024
* feat: add transaction expiration delta to `TransactionScriptBuilder` * feat: add transaction expiration delta to `TransactionRequest` * feat: add unit test * testing fix * fix: rename procedure * chore: updage CHANGELOG * fix: address suggestions * fix: doc comments
igamigo
pushed a commit
that referenced
this pull request
Nov 7, 2024
* feat: add transaction expiration delta to `TransactionScriptBuilder` * feat: add transaction expiration delta to `TransactionRequest` * feat: add unit test * testing fix * fix: rename procedure * chore: updage CHANGELOG * fix: address suggestions * fix: doc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #544
Should be merged after 0xPolygonMiden/miden-base#925
This PR adds support for transaction expiration delta in
TransactionRequest.