fix: export expiration block number procedures #925
Conversation
tomyrd
force-pushed
the
tomyrd-export-expiration-proc
branch
from
63997b4 to
293f9d4
Compare
| #! | ||
| #! Inputs: [block_height_delta, ...] | ||
| #! Output: [...] | ||
| #! | ||
| #! Where: | ||
| #! - block_height_delta is the desired expiration time delta (1 to 0xFFFF). | ||
| export.update_expiration_block_num | ||
| export.update_expiration_delta |
There was a problem hiding this comment.
I think we want to keep this name the same as it was although I don't mind this option too much either.
There was a problem hiding this comment.
I would keep the name the same here.
tomyrd
added
the
no changelog
tomyrd
changed the title
update_expiration_delta procedure
miden-lib/asm/miden/tx.masm
Outdated
| #! | ||
| #! Where: | ||
| #! - block_height_delta is the desired expiration time delta (1 to 0xFFFF). | ||
| export.update_expiration_block_num |
There was a problem hiding this comment.
I think we want update_expiration_block_delta here (ie, in the user-facing procedure), unless I misunderstood @bobbinth. If this is the case, comment on line 203 should probably be updated as well.
There was a problem hiding this comment.
Yes, exactly. From the user's standpoint, we are operating with the delta rather than the block number. So, the user should be setting and getting the current delta. The fact that we are storing it as expiration block number internally, I think, is an implementation details.
tomyrd
force-pushed
the
tomyrd-export-expiration-proc
branch
from
7b9383f to
fbfbeb1
Compare
Exposes procedures to get and set the expiration block number so that they can be used by the client