Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous return in VerifyBatches function #1441

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Fix erroneous return in VerifyBatches function #1441

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3085012
Fix erroneous return in VerifyBatches function
KonradIT Dec 5, 2022
ffaf2d5
Update ethtxmanager/ethtxmanager.go
KonradIT Dec 5, 2022
78af6d8
Update ethtxmanager/ethtxmanager.go
KonradIT Dec 5, 2022
87320ae
fix: add ErrMaxRetriesExceeded error
kind84 Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ethtxmanager/ethtxmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,10 @@ func (c *Client) VerifyBatches(ctx context.Context, lastVerifiedBatch uint64, fi
return nil, fmt.Errorf("tx %s failed, err: %w", tx.Hash(), err)
} else {
log.Infof("batch verification sent to L1 successfully. Tx hash: %s", tx.Hash())
return nil, c.state.WaitVerifiedBatchToBeSynced(ctx, finalBatchNum, c.cfg.WaitTxToBeSynced.Duration)
return tx, c.state.WaitVerifiedBatchToBeSynced(ctx, finalBatchNum, c.cfg.WaitTxToBeSynced.Duration)
if err != nil {
return nil, err
}
KonradIT marked this conversation as resolved.
Show resolved Hide resolved
}
}
return tx, nil
kind84 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down