Fix erroneous return in VerifyBatches function #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: cool-developer <[email protected]>
kind84
suggested changes
Dec 5, 2022
Co-authored-by: cool-developer <[email protected]>
cool-develope
approved these changes
Dec 5, 2022
| @@ -211,7 +211,7 @@ func (a *Aggregator) sendFinalProof() { | |||
| continue | |||
| } | |||
|
|
|||
| log.Infof("Final proof for batches %d-%d verified in transaction %v", proof.BatchNumber, proof.BatchNumberFinal, tx.Hash()) | |||
| log.Infof("Final proof for batches [%d-%d] verified in transaction [%v]", proof.BatchNumber, proof.BatchNumberFinal, tx.Hash().TerminalString()) | |||
There was a problem hiding this comment.
Do you know why this part is not covered in the test?
kind84
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @cool-develope : https://github.com/0xPolygonHermez/zkevm-node/blob/develop/ethtxmanager/ethtxmanager.go#L153
What does this PR do?
The function was returning
nil, nilwhen everything goes right.Reviewers
Main reviewers:
Codeowner reviewers: