DEVOPS-829 format Timer as summary/histogram type#893
Merged
pratikspatil024 merged 1 commit intov0.4.0-beta-candidatefrom Jun 9, 2023
Merged
DEVOPS-829 format Timer as summary/histogram type#893pratikspatil024 merged 1 commit intov0.4.0-beta-candidatefrom
pratikspatil024 merged 1 commit intov0.4.0-beta-candidatefrom
Conversation
cffls
approved these changes
Jun 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #893 +/- ##
===========================================
- Coverage 56.85% 56.79% -0.07%
===========================================
Files 617 617
Lines 73613 73613
===========================================
- Hits 41854 41809 -45
- Misses 28222 28255 +33
- Partials 3537 3549 +12
☔ View full report in Codecov by Sentry. |
pratikspatil024
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR to complete efforts from #881 as it did not produce the desired results. Digging in revealed that the metrics in question are registered as a Timer, not as Summary. Timer metrics are not part of the defined Prometheus metrics types.
This PR updates the Timer metric type to format and display as a Prometheus Summary metric (which I think was the intended behavior all along), consistent with the changes introduced in #881.
No breaking changes, all data previously presented by the metrics endpoint is still there. Formatting has been changed to follow Prometheus-type definitions, resulting in compatibility with the Open Telemetry Collector.
Changes
Checklist
Testing