DEVOPS-829 format fix for prometheus metrics#881
Merged
rekibnikufesin merged 2 commits intodevelopfrom Jun 1, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #881 +/- ##
===========================================
+ Coverage 56.82% 57.24% +0.41%
===========================================
Files 617 617
Lines 73592 105323 +31731
===========================================
+ Hits 41820 60293 +18473
- Misses 28228 41396 +13168
- Partials 3544 3634 +90
☔ View full report in Codecov by Sentry. |
cffls
approved these changes
May 31, 2023
pratikspatil024
approved these changes
Jun 1, 2023
16 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the format of
summaryandhistogrammetrics as exposed by the metrics endpoint to adhere to the Prometheus metric type definitions as seen herePrior to this change, a summary type metric would be exposed on the endpoint as two distinct metrics:
This PR updates the metric to display as:
These metrics are affected by the change: chain_account, chain_account_hashes, chain_account_reads, chain_account_updates, chain_execution, chain_inserts, chain_prefetch_executes, chain_snapshot_account_reads, chain_snapshot_commits, chain_snapshot_storage_reads, chain_storage_commits, chain_storage_hashes, chain_storage_reads, chain_storage_updates, chain_validation, chain_write, client_requests_checkpoint_duration, client_requests_checkpointcount_duration, client_requests_span_duration, client_requests_statesync_duration, eth_downloader_bodies_req, eth_downloader_headers_req, eth_downloader_receipts_req, eth_fetcher_block_announces_out, eth_fetcher_block_broadcasts_out, les_client_req_rtt, les_client_req_sendDelay, les_connection_duration, les_misc_serve_body, les_misc_serve_code, les_misc_serve_header, les_misc_serve_helperTrie, les_misc_serve_proof, les_misc_serve_receipt, les_misc_serv_txStatus, les_misc_serve_txs, les_server_blockProcessingTime, les_server_req_estimatedTime, les_server_req_relative, les_server_req_relative_body, les_server_req_relative_code, les_server_req_relative_header, les_server_req_relative_helperTrie, les_server_req_relative_proof, les_server_req_relative_receipt, les_server_req_relative_txStatus, les_server_req_relative_txs, les_server_req_servedTime, p2p_handle_eth_66_0x01-p2p_handle_eth_66_0x0a, rpc_duration_all, rpc_duration_eth_getBlockByNumber, rpc_duration_eth_getRootHash_success, state_snapshot_bloom_index, state_snapshot_dirty_account_hit_depth, state_snapshot_dirty_storage_hit_depth, trie_memcache_gc_time, txpool_dropbetweenreorg, txpool_reheap, txpool_reorgtime
Changes
Checklist
Testing