v0.3.2-beta changes#630
Merged
Merged
Conversation
Merge commits from qa into master
This reverts commit 4d19cf5.
Bump version to stable
Revert "Adding correct miner address on API at the RPC level (POS-553)"
cffls
reviewed
Dec 13, 2022
cffls
approved these changes
Dec 13, 2022
Codecov ReportBase: 56.77% // Head: 56.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## qa #630 +/- ##
==========================================
- Coverage 56.77% 56.64% -0.14%
==========================================
Files 607 608 +1
Lines 70338 70470 +132
==========================================
- Hits 39934 39915 -19
- Misses 26973 27130 +157
+ Partials 3431 3425 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This commit adds default values to CLI helper and docs. When the default value of a string flag, slice string flag, or map string flag is empty, its helper message won't show any default value.
Add default values to CLI helper and docs
313a4af to
9047365
Compare
9047365 to
b7ed9de
Compare
manav2401
approved these changes
Dec 15, 2022
| $ bor server <flags> | ||
| ``` | ||
|
|
||
| See [here](./cli/server.md) for more flag details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is reverting the RPC change for eth_getBlock
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it