Merge commits from qa into master by cffls · Pull Request #618 · 0xPolygon/bor

cffls · 2022-12-06T05:02:21Z

Description

Merge commits from qa into master.

Changes

Bugfix (non-breaking change that solves an issue)
Hotfix (change that solves an urgent issue, and requires immediate attention)
New feature (non-breaking change that adds functionality)
Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

I have added at least 2 reviewer or the whole pos-v1 team
I have added sufficient documentation in code
I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

This PR requires changes to heimdall
- In case link the PR here:
This PR requires changes to matic-cli
- In case link the PR here:

Testing

I have added unit tests
I have added tests to CI
I have tested this code manually on local environment
I have tested this code manually on remote devnet using express-cli
I have tested this code manually on mumbai
I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

…2.15-beta3-candidate

* Bump Go version to v1.18.1

This will create a static build using Go native networking stack. Checked and it works stable for all archs and distros.

* Protobuf tooling fix and upgrade * Paths for protobuf files has changed, reflect that in Makefile * Fix the tooling to make it work in macos * Update protoc version and regenarate files. * Regen proto

* Build and run the new CLI

…ker-qa Docker v0.3.0 release for QA

…on/v0.3.0packaging

…ckaging Adding in Mumbai/Mainnet precursor deb packaging for tests to use dur…

…r-rollback Docker User

* metrics: handle based config path * internal/cli/server: add more context to logs * use space separated flag and value in bor.service

* fixed static-nodes related buf (os independent) * taking static-nodes as input if default not present

* internal/cli/server: use geth's default for txpool.pricelimit and add comments * builder/files: update config.toml for mainnet * packaging/templates: update defaults for mainnet and mumbai * internal/cli/server: skip overriding cache * packaging/templates: update cache value for mainnet * packaging/templates: update gcmode for archive mumbai node

…. Added conditional check for directory structure, this is in prep for v0.3.1, as this will create a failure on upgrade path in package due to file exist

…-docker-creds

…xPolygon#607) * added a toml configuration file with comments describing each flag * internal/cli/server: update flag description * docs/cli: update example config and description of flags * docs: update new-cli docs Co-authored-by: Manav Darji <manavdarji.india@gmail.com>

…anup Cleanup for the packager to use git tag in the package profile naming…

…value and update the conversion script

Added ancient datadir flag and toml field

…ld config.toml (0xPolygon#612) * added HTTPTimeouts, and TrieTimeout flag in new tol, from old toml * added RAW fields for these time.Duration flags * updated the conversion script to support these extra 4 flags * removed hcl and json config tests as we are only supporting toml config files * updated toml files with cache.timeout field * updated toml files with jsonrpc.timeouts field * tests/bor: expect a call for latest checkpoint * tests/bor: expect a call for latest checkpoint * packaging/templates: update cache values for archive nodes Co-authored-by: Manav Darji <manavdarji.india@gmail.com>

codecov-commenter · 2022-12-06T05:24:13Z

Codecov Report

Base: 56.90% // Head: 56.92% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (57075d0) compared to base (783f93b).
Patch coverage: 35.36% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   56.90%   56.92%   +0.01%     
==========================================
  Files         578      598      +20     
  Lines       68312    69243     +931     
==========================================
+ Hits        38873    39415     +542     
- Misses      26100    26473     +373     
- Partials     3339     3355      +16

Impacted Files	Coverage Δ
consensus/bor/api.go	`0.00% <0.00%> (ø)`
consensus/bor/bor.go	`7.72% <0.00%> (+1.56%)`	⬆️
consensus/bor/errors.go	`0.00% <ø> (ø)`
consensus/bor/genesis_contract_mock.go	`0.00% <0.00%> (ø)`
consensus/bor/merkle.go	`0.00% <0.00%> (ø)`
consensus/bor/snapshot.go	`14.77% <0.00%> (+0.94%)`	⬆️
consensus/bor/span_mock.go	`0.00% <0.00%> (ø)`
consensus/bor/validators_getter_mock.go	`0.00% <0.00%> (ø)`
core/blockchain_reader.go	`43.44% <0.00%> (-3.23%)`	⬇️
core/chain_makers.go	`68.21% <0.00%> (-1.87%)`	⬇️
... and 120 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

temaniarpit27 and others added 30 commits January 12, 2022 13:00

merge geth v1.10.15

3fb2517

fix: Removed FastSync from cli server

371a411

fix: TestHeadersRLPStorage

2111d4c

Merge branch 'master' into gethv1.10.15-merge

a6c5473

Added t.skip(ETH2 in bor)

672a15e

fix: flow in create consensus engine

08509c6

bumped version

c8587b0

Fix typo

51d17ea

increase block time

555e238

remove file

111a204

Merge branch 'master' of https://github.com/maticnetwork/bor into v0.…

c8c9296

…2.15-beta3-candidate

bumped version

ebf95b9

merge gethv1.10.17

a551f01

merge master into v0.2.16-candidate

54c6db5

bumped version

44e5edf

fix failing tests

d5b76d4

Bump Go version to v1.18 (0xPolygon#368)

bf85e15

* Bump Go version to v1.18.1

Build using netgo tag

1a31178

This will create a static build using Go native networking stack. Checked and it works stable for all archs and distros.

Merge 'master' into 'v0.2.16-candidate'

0525715

Fix meta

429deab

initial implementation for common ancestor approach

cc7c5b3

extract whitelist interface

2cb82c9

fix types

aa3004b

add seperate module config for http and ws

0a63981

Do not build classic docker image

0232c6a

Protobuf tooling fix and upgrade (0xPolygon#313)

b416577

* Protobuf tooling fix and upgrade * Paths for protobuf files has changed, reflect that in Makefile * Fix the tooling to make it work in macos * Update protoc version and regenarate files. * Regen proto

Build and run the new CLI (0xPolygon#318)

66fc055

* Build and run the new CLI

start http rpc server and eth namespace by default (0xPolygon#319)

e10b10a

Add ability to run using chain json file

1ef2726

Updated file check

b398409

djpolygon and others added 22 commits November 23, 2022 09:07

Adding prerelease true

1f0e49b

Disabling goreleaser

ba56c98

Removing README swap file

c1e84fd

change bor_dir and add bor user for v0.3.0 release

08ec50a

Merge pull request 0xPolygon#592 from maticnetwork/wbutton/v0.3.0-doc…

e468e96

…ker-qa Docker v0.3.0 release for QA

Merge branch 'qa' of https://github.com/maticnetwork/bor into djpolyg…

3b6c9b0

…on/v0.3.0packaging

Merge pull request 0xPolygon#590 from maticnetwork/djpolygon/v0.3.0pa…

01e05cd

…ckaging Adding in Mumbai/Mainnet precursor deb packaging for tests to use dur…

rollback bor user and use root

5fe83d3

Merge pull request 0xPolygon#594 from maticnetwork/wbutton/docker-use…

58a6314

…r-rollback Docker User

metrics: handle equal to separated config flag (0xPolygon#596)

137fb19

* metrics: handle based config path * internal/cli/server: add more context to logs * use space separated flag and value in bor.service

fixed static-nodes related buf (os independent) (0xPolygon#598)

d69cb20

* fixed static-nodes related buf (os independent) * taking static-nodes as input if default not present

metrics: handle nil telemetry config (0xPolygon#601)

3e71609

update Docker login for goreleaser-cross v1.19

4d19cf5

Cleanup for the packager to use git tag in the package profile naming…

1cf78fd

…. Added conditional check for directory structure, this is in prep for v0.3.1, as this will create a failure on upgrade path in package due to file exist

Merge pull request 0xPolygon#610 from maticnetwork/wbutton/goreleaser…

3b4ff7d

…-docker-creds

Merge pull request 0xPolygon#611 from maticnetwork/djpolygon/v030-cle…

6cd5d15

…anup Cleanup for the packager to use git tag in the package profile naming…

added ancient datadir flag and toml field, need to decide on default …

e330329

…value and update the conversion script

updated toml files with ancient field

531d67a

Merge pull request 0xPolygon#614 from maticnetwork/ancient-datadir

dd64fa1

Added ancient datadir flag and toml field

cffls requested review from a team, pratikspatil024 and temaniarpit27 December 6, 2022 05:02

temaniarpit27 approved these changes Dec 6, 2022

View reviewed changes

cffls requested a review from a team December 6, 2022 05:32

pratikspatil024 approved these changes Dec 6, 2022

View reviewed changes

cffls merged commit 9656c6c into 0xPolygon:master Dec 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge commits from qa into master#618

Merge commits from qa into master#618
cffls merged 214 commits into
0xPolygon:masterfrom
cffls:master

cffls commented Dec 6, 2022

Uh oh!

codecov-commenter commented Dec 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

cffls commented Dec 6, 2022

Description

Changes

Breaking changes

Checklist

Cross repository changes

Testing

Manual tests

Additional comments

Uh oh!

codecov-commenter commented Dec 6, 2022

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants