Skip to content

internal/cli: add support for bor.logs flag in new-cli (#541)#542

Merged
cffls merged 1 commit into
0xPolygon:qafrom
cffls:qa
Oct 6, 2022
Merged

internal/cli: add support for bor.logs flag in new-cli (#541)#542
cffls merged 1 commit into
0xPolygon:qafrom
cffls:qa

Conversation

@cffls
Copy link
Copy Markdown
Contributor

@cffls cffls commented Oct 5, 2022

  • add support for bor.logs flag in new-cli

  • handle bor.withoutheimdall flag commenting in conversion script

* add support for bor.logs flag in new-cli

* handle bor.withoutheimdall flag commenting in conversion script
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 57.02% // Head: 56.93% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (083c3fe) compared to base (43e5d3a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa     #542      +/-   ##
==========================================
- Coverage   57.02%   56.93%   -0.09%     
==========================================
  Files         601      598       -3     
  Lines       69090    69073      -17     
==========================================
- Hits        39397    39327      -70     
- Misses      26342    26402      +60     
+ Partials     3351     3344       -7     
Impacted Files Coverage Δ
consensus/bor/bor.go 7.72% <ø> (+0.01%) ⬆️
internal/cli/server/config.go 72.91% <100.00%> (-0.34%) ⬇️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
node/defaults.go 24.13% <0.00%> (-6.90%) ⬇️
les/downloader/statesync.go 54.58% <0.00%> (-5.35%) ⬇️
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
les/utils/exec_queue.go 88.88% <0.00%> (-2.78%) ⬇️
les/servingqueue.go 56.97% <0.00%> (-2.33%) ⬇️
consensus/ethash/ethash.go 54.19% <0.00%> (-2.30%) ⬇️
accounts/keystore/account_cache.go 90.20% <0.00%> (-2.10%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cffls cffls merged commit b019a01 into 0xPolygon:qa Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants