Skip to content

internal/cli: add support for bor.logs flag in new-cli#541

Merged
manav2401 merged 2 commits into
developfrom
manav/pos-875-add-borlogs-flag
Oct 5, 2022
Merged

internal/cli: add support for bor.logs flag in new-cli#541
manav2401 merged 2 commits into
developfrom
manav/pos-875-add-borlogs-flag

Conversation

@manav2401
Copy link
Copy Markdown
Member

This PR adds support for bor.logs boolean flag in the new-cli. It also updates relevant places where it needs to be used.

All the changes have been tested on a devnet.

@manav2401 manav2401 requested a review from a team October 5, 2022 08:42
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 56.85% // Head: 56.84% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (032b640) compared to base (1022d30).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #541      +/-   ##
===========================================
- Coverage    56.85%   56.84%   -0.02%     
===========================================
  Files          606      606              
  Lines        70121    70128       +7     
===========================================
- Hits         39868    39864       -4     
- Misses       26833    26851      +18     
+ Partials      3420     3413       -7     
Impacted Files Coverage Δ
internal/cli/server/config.go 73.04% <100.00%> (+0.12%) ⬆️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
eth/peerset.go 72.34% <0.00%> (-8.52%) ⬇️
core/state_prefetcher.go 85.18% <0.00%> (-7.41%) ⬇️
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
les/distributor.go 79.68% <0.00%> (-3.13%) ⬇️
core/rawdb/chain_iterator.go 58.38% <0.00%> (-1.25%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
rpc/client.go 82.94% <0.00%> (-0.78%) ⬇️
p2p/simulations/http.go 66.02% <0.00%> (-0.65%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manav2401 manav2401 merged commit 54f97b8 into develop Oct 5, 2022
@manav2401 manav2401 deleted the manav/pos-875-add-borlogs-flag branch October 5, 2022 18:08
cffls pushed a commit to cffls/bor that referenced this pull request Oct 5, 2022
* add support for bor.logs flag in new-cli

* handle bor.withoutheimdall flag commenting in conversion script
cffls added a commit that referenced this pull request Oct 6, 2022
internal/cli: add support for bor.logs flag in new-cli (#541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants