internal/cli: add support for bor.logs flag in new-cli#541
Merged
Conversation
pratikspatil024
approved these changes
Oct 5, 2022
Codecov ReportBase: 56.85% // Head: 56.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #541 +/- ##
===========================================
- Coverage 56.85% 56.84% -0.02%
===========================================
Files 606 606
Lines 70121 70128 +7
===========================================
- Hits 39868 39864 -4
- Misses 26833 26851 +18
+ Partials 3420 3413 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
temaniarpit27
approved these changes
Oct 5, 2022
cffls
approved these changes
Oct 5, 2022
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Oct 5, 2022
* add support for bor.logs flag in new-cli * handle bor.withoutheimdall flag commenting in conversion script
cffls
added a commit
that referenced
this pull request
Oct 6, 2022
internal/cli: add support for bor.logs flag in new-cli (#541)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
bor.logsboolean flag in the new-cli. It also updates relevant places where it needs to be used.All the changes have been tested on a devnet.