fix: Remove generic constraint on graphql.scalar’s type name to improve performance
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the performance issue here is likely somewhat fixeable, TypeScript cannot be stopped from re-evaluating this. Even if `getScalarTypeNames` is just replaced with all type names, TypeScript struggles to compare a union that's this huge. Instead, we now remove the constraint entirely.
🦋 Changeset detectedLatest commit: 54e104d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Feb 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47
Summary
Retrieving a large
unionof type names and then potentially exposing thetsserverto it seems to cause a crash. Furthermore, evaluating the schema to retrieve all types, filter them by their kind, and then extracting the names seems to also cause issues.I noticed that auto-complete in place of a generic isn't possible anyway, so we can save ourselves the effort. We can potentially readd it to the
graphql.scalarargument itself, but it doesn't really seem worth it.Set of changes
getScalarTypeNamesgraphql.scalar