Remove unnecessary object initializations from HtmlNodeNavigator.Clone() #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, We will look at it. My developer already looking last Friday at your first request but he told me that was causing some issue. So I wanted to look at it myself before answering. I will make him test your pull request first. Maybe he did something wrong. |
|
Sorry for the long delay, We are finally able to work again on HAP (we had lot of internal stuff to complete first). The v1.11.13 has been released with your code. Thank again for your pull request. Best Regards, Jonathan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #324
HtmlNodeNavigator.Clone()is called repeatedly when executingHtmlNode.SelectNodes. Each call creates instances ofHtmlDocumentandNameTablewhich are immediately overwritten by the cloned values.The fix removes the inline field assignments and moves them into the constructors, wherever needed.