Skip to content

[feat] reuse existing tests and remove the error config of reward models#1

Merged
zzong2006 merged 1 commit intozzong2006:support_moe_offload_when_ep_more_than_onefrom
ETOgaosion:support_moe_offload_when_ep_more_than_one
May 23, 2025
Merged

[feat] reuse existing tests and remove the error config of reward models#1
zzong2006 merged 1 commit intozzong2006:support_moe_offload_when_ep_more_than_onefrom
ETOgaosion:support_moe_offload_when_ep_more_than_one

Conversation

@ETOgaosion
Copy link
Copy Markdown

Checklist Before Starting

  • Search for similar PR(s).

What does this PR do?

reuse existing tests and remove the error config of reward models

High-Level Design

Demonstrate the high-level design if this PR is complex.

Specific Changes

List the specific changes.

API

Demonstrate how the API changes if any.

Usage Example

Provide usage example(s) for easier usage.

# Add code snippet or script demonstrating how to use this 

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluatuion results, etc.

Additional Info.

  • Issue Number: Fixes issue # or discussion # if any.
  • Training: [Note which backend this PR will affect: FSDP, Megatron, both, or none]
  • Inference: [Note which backend this PR will affect: vLLM, SGLang, both, or none]

Checklist Before Submitting

  • Read the Contribute Guide.
  • Apply pre-commit checks.
  • Add [BREAKING] to the PR title if it breaks any API.
  • Update the documentation about your changes in the docs.
  • Add CI test(s) if necessary.

@zzong2006 zzong2006 merged commit 4105358 into zzong2006:support_moe_offload_when_ep_more_than_one May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants