Skip to content

Commit

Permalink
fix(docs): fix broken icon link in Tutorial Part Eight (gatsbyjs#15000)
Browse files Browse the repository at this point in the history
In the current version of the tutorial, the link to the example icon leads here: https://www.gatsbyjs.org/tutorial/part-eight/icon.png, which turns up as a "Page not found" (assuming this is a 404).

It looks like the link to the icon isn't accounted for in the build process. Following the contributing suggestions [here](https://www.gatsbyjs.org/contributing/gatsby-style-guide/#format-code-blocks-inline-code-and-images), I'm grabbing the raw source for the icon, which is [this link](https://raw.githubusercontent.com/gatsbyjs/gatsby/master/docs/tutorial/part-eight/icon.png).

Please let me know if there's a better way to include a live link to this icon (a cloudinary link, some other link, etc.).
  • Loading branch information
n8finch authored and gillkyle committed Jun 25, 2019
1 parent 5f89f23 commit fc2bdf2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/tutorial/part-eight/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Quoting [Google](https://developers.google.com/web/fundamentals/web-app-manifest
npm install --save gatsby-plugin-manifest
```

2. Add a favicon for your app under `src/images/icon.png`. For the purposes of this tutorial you can use [this example icon](./icon.png), should you not have one available. The icon is necessary to build all images for the manifest. For more information, look at the docs for [`gatsby-plugin-manifest`](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-manifest/README.md).
2. Add a favicon for your app under `src/images/icon.png`. For the purposes of this tutorial you can use [this example icon](https://raw.githubusercontent.com/gatsbyjs/gatsby/master/docs/tutorial/part-eight/icon.png), should you not have one available. The icon is necessary to build all images for the manifest. For more information, look at the docs for [`gatsby-plugin-manifest`](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-manifest/README.md).

3. Add the plugin to the `plugins` array in your `gatsby-config.js` file.

Expand Down

0 comments on commit fc2bdf2

Please sign in to comment.