Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text fixes #742

Merged
merged 27 commits into from
Feb 18, 2024
Merged

Text fixes #742

merged 27 commits into from
Feb 18, 2024

Conversation

misos1
Copy link
Contributor

@misos1 misos1 commented Nov 12, 2023 •
edited
Loading

  • fixes grammatical errors, correct names of historical figures like Dacenport->Davenport https://en.wikipedia.org/wiki/Emily_Davenport
  • normalizes styles of abbreviations
  • normalizes US vs UK english to just one of them
  • normalizes capitalization to match rimworld style
  • fixes "intemacractions" - it has zero results when searching on internet
  • made up words like "growzone", "mechanite", "holographam" are left unchanged
  • fixes double > in <description>>
  • normalizes double spaces, space after or before \n, physical newlines in description, periods at end of descriptions
  • ignores comments unless commented part is part of xml
  • fixes "undefinedundefined"
  • does not touch older versions like 1.2 and 1.3 and translations other than english

@misos1
fix whitespaces
ce978c0 
- double spaces, space after or before \n, physical newlines in description
- ignores comments unless commented part was once part of xml
- does not touch older versions like 1.2 and 1.3 and translations other than english
- "undefinedundefined"
@misos1
fix texts
172cdef 
- "intemacractions" has zero results when searching on internet
- does not touch "holographam"?
- "growzone" is left unchanged
- fixed double > in "<description>>"
- does not touch older versions like 1.2 and 1.3 and translations other than english
@misos1
fix some overlooks
51c2f30 
- normalize S.A.L abbreviation
@misos1
normalize capitalization of labels and descriptions
0eb3296
@misos1
revert changing "nutrient paste"
a75ac06 
- as this is how it is called in other mods - without hyphen
@misos1 misos1 marked this pull request as ready for review November 15, 2023 20:14
@misos1 misos1 marked this pull request as draft November 15, 2023 20:37
@misos1
Revert "revert changing "nutrient paste""
aae9966 
This reverts commit a75ac06.
@misos1
Revert "normalize capitalization of labels and descriptions"
57d91ea 
This reverts commit 0eb3296.
@misos1
start labels with lowercase
863f4c2 
- except when it starts with abbreviation or when it is proper noun
- achievements elsewhere are mostly fully capitalized
@misos1
capitalize descriptions
db310ca
@misos1 misos1 marked this pull request as ready for review November 16, 2023 21:03
@Sn1p3rr3c0n Sn1p3rr3c0n self-requested a review November 24, 2023 11:19
Sn1p3rr3c0n
Sn1p3rr3c0n reviewed Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@Sn1p3rr3c0n Sn1p3rr3c0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope that this comment makes my previous comments visible

Defs/AchievementsExpanded/Achievements.xml Outdated Show resolved Hide resolved
Defs/RecipeDefs/Recipes_Fermentation.xml Outdated Show resolved Hide resolved
Defs/RecipeDefs/Recipes_Items.xml Show resolved Hide resolved
Patches/SimpleFridge.xml Show resolved Hide resolved
Patches/RimFridge.xml Show resolved Hide resolved
Defs/ThingDefs_Buildings/Buildings_Assemblers.xml Outdated Show resolved Hide resolved
Defs/ThingDefs_Buildings/Buildings_Assemblers.xml Outdated Show resolved Hide resolved
Defs/ThingDefs_Buildings/Buildings_Miners.xml Outdated Show resolved Hide resolved
Patches/Drones/RimAtomics.xml Outdated Show resolved Hide resolved
Defs/ThingDefs_Buildings/Lighting_FloorLamp.xml Outdated Show resolved Hide resolved
Sn1p3rr3c0n
Sn1p3rr3c0n reviewed Dec 28, 2023
View reviewed changes
Languages/English/Keyed/AllKeyed_Settings.xml
<PRF_Settings_C_Patches_Reachability_CanReach>Toggle the Advanced IO CanReach Patch</PRF_Settings_C_Patches_Reachability_CanReach>
<PRF_Settings_C_Patches_WealthWatcher_CalculateWealthItems_ToolTip>Toggles the Cold Storage WealthWatcher Patch\n\nWhen checked the Patch is active and items in Cold Storage contribute to Colony Wealth.\n\nFor most Players we reccomend this to be on.\nPerformance load on this is ~1ms per 1,000 stored items. This runs every 5,000 Ticks\n\n(ProjectRimFactory.Common.HarmonyPatches.Patch_WealthWatcher_CalculateWealthItems:Postfix)</PRF_Settings_C_Patches_WealthWatcher_CalculateWealthItems_ToolTip>
<PRF_Settings_C_Patches_WealthWatcher_CalculateWealthItems_ToolTip>Toggles the Cold Storage WealthWatcher Patch.\n\nWhen checked, the patch is active and items in Cold Storage contribute to colony wealth.\n\nFor most players, we recommend this to be on.\nPerformance load on this is ~1ms per 1,000 stored items. This runs every 5,000 ticks.\n\n(ProjectRimFactory.Common.HarmonyPatches.Patch_WealthWatcher_CalculateWealthItems:Postfix)</PRF_Settings_C_Patches_WealthWatcher_CalculateWealthItems_ToolTip>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, I think that key is unused

Sn1p3rr3c0n
Sn1p3rr3c0n requested changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@Sn1p3rr3c0n Sn1p3rr3c0n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey I'm done with all files now.
I would want to go over the Comments, please feel free to correct me if i got things wrong.

Sn1p3rr3c0n
Sn1p3rr3c0n reviewed Feb 16, 2024
View reviewed changes
Patches/RimFridge.xml Outdated Show resolved Hide resolved
@Sn1p3rr3c0n
Copy link
Collaborator

I have gone over the changes and left my comments.
I have also resolved ald comments where applicable in fact the only 2 still open is a note to myself and one with no response atm: #742 (comment)

Sn1p3rr3c0n
Sn1p3rr3c0n approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@Sn1p3rr3c0n Sn1p3rr3c0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Sn1p3rr3c0n Sn1p3rr3c0n merged commit c2b2aec into zymex22:master Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sn1p3rr3c0n Sn1p3rr3c0n Sn1p3rr3c0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misos1 @Sn1p3rr3c0n