Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization Patch_Building_Storage_Accepts #678

Closed
Sn1p3rr3c0n opened this issue Feb 18, 2023 · 1 comment · Fixed by #679 or #708
Closed

Optimization Patch_Building_Storage_Accepts #678

Sn1p3rr3c0n opened this issue Feb 18, 2023 · 1 comment · Fixed by #679 or #708
Labels
C#

Comments

@Sn1p3rr3c0n
Copy link
Collaborator

We received a report on Dubs Discord by Helix#8384 where Patch_Building_Storage_Accepts was performing not as well as we would hope.
Patch_Building_Storage_Accepts_initialReport
The Screenshot of the Internal Profile already looked better
Patch_Building_Storage_Accepts_Internal
Sn1p3rr3c0n added a commit that referenced this issue Feb 18, 2023
@Sn1p3rr3c0n
#678 removed unnessesary checks
2b1bc94
@Sn1p3rr3c0n Sn1p3rr3c0n mentioned this issue Feb 18, 2023
Merged
Sn1p3rr3c0n added a commit that referenced this issue Feb 24, 2023
@Sn1p3rr3c0n
Merge pull request #679 from zymex22/issue678
4b8dc51 
#678 removed unnecessary checks
@Sn1p3rr3c0n Sn1p3rr3c0n mentioned this issue Apr 13, 2023
Merged
@Sn1p3rr3c0n
Copy link
Collaborator Author

As noted in #699 and #702 This issue needs to be reopened
We shall check if the function can be optimized without affecting the now discovered purpose of those lines

@Sn1p3rr3c0n Sn1p3rr3c0n reopened this Apr 13, 2023
@Sn1p3rr3c0n Sn1p3rr3c0n added the C# label Apr 13, 2023
Sn1p3rr3c0n added a commit that referenced this issue Apr 24, 2023
@Sn1p3rr3c0n
#678 Optimized Patch_Building_Storage_Accepts
837cd80
@Sn1p3rr3c0n Sn1p3rr3c0n mentioned this issue Apr 24, 2023
Merged
Sn1p3rr3c0n added a commit that referenced this issue Jun 1, 2023
@Sn1p3rr3c0n
Merge pull request #708 from zymex22/issue678_v2
8182016 
#678 Optimized Patch_Building_Storage_Accepts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
1 participant
@Sn1p3rr3c0n