Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Mod Compatibility) Updated Locks 2 Mod requires an Update Support Patch #668

Closed
Sn1p3rr3c0n opened this issue Dec 6, 2022 · 2 comments · Fixed by #676
Closed

(Mod Compatibility) Updated Locks 2 Mod requires an Update Support Patch #668

Sn1p3rr3c0n opened this issue Dec 6, 2022 · 2 comments · Fixed by #676
Labels
bug Something isn't working C#

Comments

@Sn1p3rr3c0n
Copy link
Collaborator

The Updated version of Locks 2 is not compatible with the old Support Patch.
https://gist.github.com/HugsLibRecordKeeper/7befc1305041229b75037b3431511607#file-output_log-txt-L3278
AmbiguousMatchException

We should probably consider changing how the patch currently works, since it needs to be updated anyway.
The current version allows Drones to pass if they are allowed by race.
Maybe we should just treat them as colonists, instead of requiring users to add a race check.

@Sn1p3rr3c0n Sn1p3rr3c0n added bug Something isn't working C# labels Dec 6, 2022
@martin-arg
Copy link

Hi I'm not sure if it is the same error, but even if I deactivate drones I still receive this error relate with locks 2.

logs.txt

@Sn1p3rr3c0n
Copy link
Collaborator Author

by now they have a Allow mechs Setting that is available even without Biotech and is Toggled on by default.
It works as expected with Drones.
Therefore we no longer need a compatibility Patch. the old Patch can be removed on our side
image

Sn1p3rr3c0n added a commit that referenced this issue Feb 4, 2023
Sn1p3rr3c0n added a commit that referenced this issue Feb 4, 2023
#668 removed obsolete Locks2 Patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C#
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants